From: Nobuyoshi Nakada <nobu@...>
Date: 2016-01-27T18:19:17+09:00
Subject: [ruby-core:73528] Re: [ruby-cvs:60830] duerst:r53669 (trunk): * enc/unicode.c: Protect code point count by macro, in order to

--===============0492116105==
Content-Type: multipart/alternative; boundary=001a114a7974e8a0ef052a4d4b41

--001a114a7974e8a0ef052a4d4b41
Content-Type: text/plain; charset=UTF-8

> duerst  2016-01-27 17:55:40 +0900 (Wed, 27 Jan 2016)
>
>   New Revision: 53669
>
>
> https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=53669
>
>   Log:
>     * enc/unicode.c: Protect code point count by macro, in order to
>       be able to use the remaining bits for flags.
>       (with Kimihito Matsui)


Is this really intended?

> +/* use bottom bytes for actual code point count; 3 bits is more than
enough */ > +#define OnigCodePointCount(n) ((n)&0x111)

I suspect that you may want to write `0b111`, but binary literal isn't
available in C.

--001a114a7974e8a0ef052a4d4b41
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-lef=
t:1px #ccc solid;padding-left:1ex">duerst=C2=A0 2016-01-27 17:55:40 +0900 (=
Wed, 27 Jan 2016)<br>
<br>
=C2=A0 New Revision: 53669<br>
<br>
=C2=A0 <a href=3D"https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=3Drevis=
ion&amp;revision=3D53669" target=3D"_blank">https://svn.ruby-lang.org/cgi-b=
in/viewvc.cgi?view=3Drevision&amp;revision=3D53669</a><br>
<br>
=C2=A0 Log:<br>
=C2=A0 =C2=A0 * enc/unicode.c: Protect code point count by macro, in order =
to<br>
=C2=A0 =C2=A0 =C2=A0 be able to use the remaining bits for flags.<br>
=C2=A0 =C2=A0 =C2=A0 (with Kimihito Matsui)</blockquote><div><span style=3D=
"background-color:rgba(255,255,255,0);font-size:medium"><br></span></div><d=
iv><span style=3D"background-color:rgba(255,255,255,0);font-size:medium">Is=
 this really intended?</span></div><div><br></div><div><span style=3D"backg=
round-color:rgba(255,255,255,0)">&gt;=C2=A0</span><span style=3D"background=
-color:rgba(255,255,255,0);font-size:medium">+/* use bottom bytes for actua=
l code point count; 3 bits is more than enough */ &gt;=C2=A0+#define OnigCo=
dePointCount(n) ((n)&amp;0x111)</span></div><div><span style=3D"background-=
color:rgba(255,255,255,0);font-size:medium"><br></span></div><div><span sty=
le=3D"background-color:rgba(255,255,255,0);font-size:medium">I suspect that=
 you may want to write `0b111`, but binary literal isn&#39;t available in C=
.</span></div><div><span style=3D"background-color:rgba(255,255,255,0);font=
-size:medium"><br></span></div>

--001a114a7974e8a0ef052a4d4b41--

--===============0492116105==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

--===============0492116105==--