[ruby-core:72658] [Ruby trunk - Bug #11901] Performance Issue with OpenStruct

Issue #11901 has been updated by Marc-Andre Lafortune.


Yui NARUSE wrote:
> Could you fix rubyspec?

Great, that was a bug

I made an easy fix so `method_missing` doesn't add a method if frozen. I hesitated to redefine `freeze` to add all the needed method definitions, but it's difficult to know if it would be preferable.

----------------------------------------
Bug #11901: Performance Issue with OpenStruct
https://bugs.ruby-lang.org/issues/11901#change-55909

* Author: Ariel Caplan
* Status: Closed
* Priority: Normal
* Assignee: Marc-Andre Lafortune
* ruby -v: ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin13]
* Backport: 2.3: REQUIRED
----------------------------------------
After recent changes to define OpenStruct getter/setter methods lazily, there is a heavy performance impact for the use case where an attribute is assigned at initialization time (i.e. `Openstruct.new(foo: :bar)`).  Once an attribute is stored in the internal hash, the appropriate singleton methods will never be defined, due to the recent changes to OpenStruct's `#respond_to_missing?` - meaning that every time I call `#foo` or `#foo=` it relies on `#method_missing`.  Benchmark using benchmark-ips is attached.

I'm primarily concerned about the case of configuration objects, which may be populated at initialization time and then accessed many times throughout the life of the program.

---Files--------------------------------
openstruct-regression-benchmark.rb (1.36 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>