From: matz@... Date: 2016-01-30T02:57:49+00:00 Subject: [ruby-core:73594] [Ruby trunk - Bug #11762] Array#dig can raise TypeError: no implicit conversion of Symbol/String into Integer Issue #11762 has been updated by Yukihiro Matsumoto. Andrew, I don't think `dig!` is a good name, because `!` usually denotes dangerous version of a method in Ruby naming convention. Colin, Thank you for the investigation. Your survey means most code does not consider exceptional cases. So `dig` should be, I think. If you really want `nil` from corrupted tree, just add `rescue nil` after `dig` call. It's much better, I think, because we can't distinguish optional value and corrupted tree once we give `nil` from `dig` for both cases. Matz. ---------------------------------------- Bug #11762: Array#dig can raise TypeError: no implicit conversion of Symbol/String into Integer https://bugs.ruby-lang.org/issues/11762#change-56789 * Author: Colin Kelley * Status: Closed * Priority: Normal * Assignee: Yukihiro Matsumoto * ruby -v: 2.3.0-preview2 * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- If you try to `dig` in an Array using a symbol or string, a `TypeError` exception will be raised: irb> ['zero', 'one', 'two'].dig(:first) TypeError: no implicit conversion of Symbol into Integer from (irb):1:in `dig' from (irb):1 I think it should return `nil` in this case. The most typical use case for `dig` is to dig through parsed JSON and either find the result we expected or else `nil`. Wouldn't it defeat the purpose of `dig` if we had to wrap calls to it in a `rescue` to handle the case that an Array was present where we expected a Hash? Can we clarify the desired behavior for this case, then update the documentation and tests to reflect that? ---Files-------------------------------- 11762.patch (3.19 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: