From: "ko1 (Koichi Sasada)" <redmine@...>
Date: 2013-01-25T12:06:04+09:00
Subject: [ruby-core:51629] [ruby-trunk - Bug #6750] Comment above rb_iseq_struct.local_size gives out of date description


Issue #6750 has been updated by ko1 (Koichi Sasada).


I'm sorry I missed this issue (because no "target version". sorry again).
I applied it.

Thanks!
----------------------------------------
Bug #6750: Comment above rb_iseq_struct.local_size gives out of date description
https://bugs.ruby-lang.org/issues/6750#change-35590

Author: davidbalbert (David Albert)
Status: Closed
Priority: Normal
Assignee: ko1 (Koichi Sasada)
Category: 
Target version: 
ruby -v: 2.0.0dev


The description of rb_iseq_struct.local_size says that it is sizeof(local vars) + 1 for class and method frames, but just sizeof(local vars) for block frames. I think this is no longer the case. local_size is always sizeof(local vars) + 1.

Here's the relevant code from when the comment was written (2007): https://github.com/ruby/ruby/blob/71986ef6bc232455deca67017873fff0c3cbd860/compile.c#L5004-5010
And here's the code today: https://github.com/ruby/ruby/blob/trunk/compile.c#L5571

I've attached a patch that fixes the comment.


-- 
http://bugs.ruby-lang.org/