[ruby-core:123158] [Ruby Feature#21556] Add true? and false? methods to NilClass, TrueClass, FalseClass, and String

Issue #21556 has been updated by Phalado (Raphael Cordeiro).


shan (Shannon Skipper) wrote in #note-4:
> I wonder if the inclusion of the String variant could be considered again even though it has been merged? Is there a domain where `"true"` and `"false"` Strings are used? The Rails variant trying to support env vars makes more sense to me than `string == 'true'` test since you can `string == 'true'` trivially. Having `"True".true? #=> false` seems a bit counterintuitive.
> 
> I think the true/false/nil ones seem totally make sense.
> 
> Edit: Rereading the issue, I think I somehow missed that the point of the feature was bool and String both being supported. Sorry for the noise. I'm still curious if a mix of String of exactly true/false Strings and bool is something typical?

The idea here came when working with JSON from requests and, especially, Active Admin. Users sometimes fill boolean values as true, other times as "true", which can be a problem if you are expecting a boolean or a string specifically. Also, a nil value can be considered 'false', which is not always the case when treating data.

So, instead of checking for nil, converting it to string and, in the end, checking if it'1s equal to 'true' or 'false' (kinda converting to boolean) I came with this, where Strings, Booleans and Nil values can live together in harmony.

----------------------------------------
Feature #21556: Add true? and false? methods to NilClass, TrueClass, FalseClass, and String
https://bugs.ruby-lang.org/issues/21556#change-114492

* Author: Phalado (Raphael Cordeiro)
* Status: Feedback
----------------------------------------
Sometimes we need to check for an exact `true` or `false` value. This can be a string or a boolean value.

Usually, what I do to solve this is something like `value.to_s == true`, this way covering for strings, booleans, and nil values.

The idea of these new methods is to check for the exact value, being it a String, a Boolean, or even a Nil value.

This is the result obtained:

``` ruby
# String

'true'.true? # true
'false'.true? # false
''.true? # false

'true'.false? # false
'false'.false? # true
''.false? # false

# Boolean

true.true? # true
true.false? # false

false.true? # false
false.false? # true

# Nil

nil.true? # false
nil.false? # false
```




-- 
https://bugs.ruby-lang.org/
______________________________________________
 ruby-core mailing list -- [e-mail]
 To unsubscribe send an email to [e-mail]
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/