[ruby-core:67769] [ruby-trunk - Misc #10754] Tiny optimisation of Set#include?

Issue #10754 has been updated by Eric Wong.


 I didn't notice the old code being faster, and I don't see your
 benchmark triggering GC.  Perhaps it is related to memory size
 (swapping or CPU cache misses) or power management
 (CPU clock frequency adjustment, "turbo boost", etc...)
 Modern hardware is tricky to benchmark :/

----------------------------------------
Misc #10754: Tiny optimisation of Set#include?
https://bugs.ruby-lang.org/issues/10754#change-51193

* Author: Ismael Abreu
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Hi!

I'm not sure if this a relevant optimisation but here it goes. A simple way to improve Set#include?
I don't think there should be any side effects with this change.

Here are some dummy benchmarks https://gist.github.com/ismaelga/68bb3ea51b4742f65699
They are not consistent, but that should be because of garbage collection or something. Right?

I've also sent a Pull Request: https://github.com/ruby/ruby/pull/810

---Files--------------------------------
patch.diff (544 Bytes)


-- 
https://bugs.ruby-lang.org/