From: normalperson@...
Date: 2015-01-12T09:28:32+00:00
Subject: [ruby-core:67533] [ruby-trunk - Misc #10721] Failing test because	of DNS server

Issue #10721 has been updated by Eric Wong.


 e@zzak.io wrote:
 > Were you working on a similar patch?
 
 Not really, r49175 was because I was offline completely.
 Anthony's ISP is online and doing bad things, but his patch
 looks good to me.
 
 I can commit _v2 of his patch in a day or so (unless anybody has
 objections).  I'll shorten "the dns_lookup_failure_message" variable
 name to "failure_message" so it fits in 80 columns.

----------------------------------------
Misc #10721: Failing test because of DNS server
https://bugs.ruby-lang.org/issues/10721#change-50947

* Author: Anthony Crumley
* Status: Assigned
* Priority: Normal
* Assignee: Eric Wong
----------------------------------------
The following test is failing:

[ 5/52] TestNetHTTP#test_failure_message_includes_failed_domain_and_port = 0.32 s
  1) Failure:
TestNetHTTP#test_failure_message_includes_failed_domain_and_port [/vagrant/test/net/http/test_http.rb:196]:
Expected "should have raised" to include "doesnotexist.bogus:80".

The problem is caused by my ISP, Charter Cable, returning a search results page instead of a failed DNS lookup for http://doesnotexist.bogus.  If I change my DNS server setting on my computer to use Google DNS then the test passes.  

The attached patch uses a MiniTest stub to produce the DNS failure which results in the expected error message regardless of how the machine's DNS server responds to http://doesnotexist.bogus.

Thanks for everything you all do,

Anthony

---Files--------------------------------
dns_lookup.patch (1.06 KB)
dns_lookup_v2.patch (1.18 KB)


-- 
https://bugs.ruby-lang.org/