From: normalperson@...
Date: 2015-01-18T01:58:42+00:00
Subject: [ruby-core:67667] [ruby-trunk - Misc #10754] Tiny optimisation of	Set#include?

Issue #10754 has been updated by Eric Wong.


 This speedup probably happens because Hash#[] has an optimized dispatch
 VM instruction (opt_aref in insns.def) while Hash#include? does not.
 
 Seems like an OK change to make, I'll commit in a few days unless others
 raise objections.

----------------------------------------
Misc #10754: Tiny optimisation of Set#include?
https://bugs.ruby-lang.org/issues/10754#change-51082

* Author: Ismael Abreu
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Hi!

I'm not sure if this a relevant optimisation but here it goes. A simple way to improve Set#include?
I don't think there should be any side effects with this change.

Here are some dummy benchmarks https://gist.github.com/ismaelga/68bb3ea51b4742f65699
They are not consistent, but that should be because of garbage collection or something. Right?

I've also sent a Pull Request: https://github.com/ruby/ruby/pull/810

---Files--------------------------------
patch.diff (544 Bytes)


-- 
https://bugs.ruby-lang.org/