From: leif.eriksen.au@...
Date: 2015-01-19T09:54:19+00:00
Subject: [ruby-core:67685] [ruby-trunk - Bug #10733] Time.httpdate raises ArgumentError when DateTime.now.httpdate is provided as input

Issue #10733 has been updated by Leif Eriksen.


ok, the US-ASCII encoding is not having its space consumed as the regex matches! I've extracted the part of the regex from Time.httpdate that is working, and looking at the post-match parts - they should be the same.

```
def local_httpdate(date)
  if /
      \A
      \s*
      (?:Mon|Tue|Wed|Thu|Fri|Sat|Sun),\x20
    /ix =~ date
    puts $'
  end
end

date_UTF      = "Mon, 19 Jan 2015 08:43:19 GMT".encode(Encoding.find('UTF-8'))
date_US_ASCII = "Mon, 19 Jan 2015 08:43:19 GMT".encode(Encoding.find('US-ASCII'))

local_httpdate(date_UTF) # Works
local_httpdate(date_US_ASCII) # => ArgumentError
```

~~~
~/src/bugs/10733 bundle exec ruby 10733.rb
19 Jan 2015 08:43:19 GMT
 19 Jan 2015 08:43:19 GMT
~~~

What should I do ? Raise a separate issue ? I know from the dumping the strings and looking at the ordinal values that the spaces in both encodings are \x20 chars.

----------------------------------------
Bug #10733: Time.httpdate raises ArgumentError when DateTime.now.httpdate is provided as input
https://bugs.ruby-lang.org/issues/10733#change-51104

* Author: Maarten Claes
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-darwin14]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
An irb session demonstrating the bug:

```
irb(main):001:0> require 'time'
=> true
irb(main):002:0> Time.httpdate("Mon, 12 Jan 2015 12:04:15 GMT")
=> 2015-01-12 12:04:15 UTC
irb(main):003:0> DateTime.now.httpdate.to_s
=> "Mon, 12 Jan 2015 12:04:56 GMT"
irb(main):004:0> Time.httpdate(DateTime.now.httpdate.to_s)
ArgumentError: not RFC 2616 compliant date: "Mon, 12 Jan 2015 12:05:08 GMT"
        from /Users/mcls/.rbenv/versions/2.2.0/lib/ruby/2.2.0/time.rb:544:in `httpdate'
        from (irb):4
        from /Users/mcls/.rbenv/versions/2.2.0/bin/irb:11:in `<main>'
```

To reproduce:
```
require 'time'
Time.httpdate("Mon, 12 Jan 2015 12:04:15 GMT") # works
Time.httpdate(DateTime.now.httpdate.to_s) # => ArgumentError
```

It seems that this only occurs on 2.2.0. (Tested on 2.1.5 and it works fine)



-- 
https://bugs.ruby-lang.org/