[ruby-core:67468] [ruby-trunk - misc #10721] Failing test because of DNS server

Issue #10721 has been updated by Anthony Crumley.

File dns_lookup_v2.patch added

Improved the original solution by adding assert_raises.

----------------------------------------
misc #10721: Failing test because of DNS server
https://bugs.ruby-lang.org/issues/10721#change-50888

* Author: Anthony Crumley
* Status: Open
* Priority: Normal
* Assignee: 
* Category: test
* Target version: 
----------------------------------------
The following test is failing:

[ 5/52] TestNetHTTP#test_failure_message_includes_failed_domain_and_port = 0.32 s
  1) Failure:
TestNetHTTP#test_failure_message_includes_failed_domain_and_port [/vagrant/test/net/http/test_http.rb:196]:
Expected "should have raised" to include "doesnotexist.bogus:80".

The problem is caused by my ISP, Charter Cable, returning a search results page instead of a failed DNS lookup for http://doesnotexist.bogus.  If I change my DNS server setting on my computer to use Google DNS then the test passes.  

The attached patch uses a MiniTest stub to produce the DNS failure which results in the expected error message regardless of how the machine's DNS server responds to http://doesnotexist.bogus.

Thanks for everything you all do,

Anthony

---Files--------------------------------
dns_lookup.patch (1.06 KB)
dns_lookup_v2.patch (1.18 KB)


-- 
https://bugs.ruby-lang.org/