Re: [ ruby-Patches-1939 ] Pathname, totally revamped

--- Mark Hubbart <[e-mail]> wrote:

<snip>
 
> I think the point that is being made here is that it
> modifies the
> actual string sent to the function, which is bad
> behavior, since it
> can cause all sorts of surprises:
> 
> path = Config::CONFIG['libdir'] 
> #==>"/path/to/libdir"
> pn = Pathname.new(path)
> Config::CONFIG['libdir']        
> #==>"\path\to\libdir"

How would one end up with "/path/to/libdir" on Win32? 
Cygwin, etc, would not have the slashes transformed.
 
> A better solution would be to change the tr line
> from
>      path.tr!("/",@sep) if File::ALT_SEPARATOR
> to
>      path = path.tr("/",@sep) if File::ALT_SEPARATOR
> which will leave the original string unmodified.

Ah, well, ok then.  I'll do that. :)

Also, I'll replace File::ALT_SEPARATOR with a PLATFORM
check, add a Pathname#each method, and add a few more
tests.

Thanks.

Dan

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com