From: Eric Hodel Date: 2005-05-18T04:22:50+09:00 Subject: Re: Forwardable, reworked On 17 May 2005, at 11:38, Berger, Daniel wrote: >> -----Original Message----- >> From: Eric Hodel [mailto:drbrain@segment7.net] >> Sent: Tuesday, May 17, 2005 11:05 AM >> To: ruby-core@ruby-lang.org >> Subject: Re: Forwardable, reworked >> >> I think I would rather see: >> >> delegate :@number, :to_i >> delegate :@string, :to_s, :reverse >> >> def delegate(ivar, *methods) >> methods.each { |method| def_instance_delegator ivar, method } end >> > > It's six one way and half a dozen the other. Both look good to me, > though the officially submitted patch uses the reversed, hash style > that > Florian originally suggested. If you feel strongly about it, please > post a response to Patch 1923 on RubyForge. Matz and/or Tanaka may > agree with you. Agreed, I only felt strongly enough to mention it here. >> The kind_of? feels so clumsy. (And I forgot how String#each worked >> since I never use it.) >> > > Actually, I replaced that line in the submitted patch with: > > methods = methods.to_s unless methods.respond_to?(:each). Just a wee > bit of duck typing to keep things sane. Great! -- Eric Hodel - drbrain@segment7.net - http://segment7.net FEC2 57F1 D465 EB15 5D6E 7C11 332A 551C 796C 9F04