ruby-dev

前田です。

2008/08/25 21:30 Shugo Maeda <shugo@ruby-lang.org>:
>> (1) メソッドを追加するクラス・メソッド名はこのままでよいでしょうか。
>> (2) インスタンス単位で指定できるようにする必要はないでしょうか。
>>
>> (1)について問題なければ、(2)については後で追加でもよいかもしれません。
>
> もう一点、上限に引っかかった時に発生する例外がRuntimeErrorでいいかどうか
> というのがありました。
>
>  raise "Number of entity expansions exceeded, processing aborted."
>
> ちなみに、REXMLで定義している例外は以下の二つですが、RuntimeErrorを
> raiseしている部分も多いようです。
>
> * REXML::ParseException
> * REXML::Validation::ValidationException

とりあえず、外部的なインタフェイスはmonkey patchからあまり変えない方向で
trunkに適用してみました。
# trunkの方が1.8より3倍くらい速いですね。

-- 
Shugo Maeda

Attachments (1)

entity_expansion_limit.diff (3.14 KB, text/x-diff)

Index: lib/rexml/document.rb
===================================================================
--- lib/rexml/document.rb	(revision 18834)
+++ lib/rexml/document.rb	(working copy)
@@ -32,6 +32,7 @@
 	  # @param context if supplied, contains the context of the document;
 	  # this should be a Hash.
 		def initialize( source = nil, context = {} )
+      @entity_expansion_count = 0
 			super()
 			@context = context
 			return if source.nil?
@@ -200,6 +201,27 @@
 			Parsers::StreamParser.new( source, listener ).parse
 		end
 
+    @@entity_expansion_limit = 10_000
+
+    # Set the entity expansion limit. By defualt the limit is set to 10000.
+    def Document::entity_expansion_limit=( val )
+      @@entity_expansion_limit = val
+    end
+
+    # Get the entity expansion limit. By defualt the limit is set to 10000.
+    def Document::entity_expansion_limit
+      return @@entity_expansion_limit
+    end
+
+    attr_reader :entity_expansion_count
+    
+    def record_entity_expansion
+      @entity_expansion_count += 1
+      if @entity_expansion_count > @@entity_expansion_limit
+        raise "number of entity expansions exceeded, processing aborted."
+      end
+    end
+
 		private
 		def build( source )
       Parsers::TreeParser.new( source, self ).parse
Index: lib/rexml/entity.rb
===================================================================
--- lib/rexml/entity.rb	(revision 18834)
+++ lib/rexml/entity.rb	(working copy)
@@ -73,6 +73,7 @@
 		# all entities -- both %ent; and &ent; entities.  This differs from
 		# +value()+ in that +value+ only replaces %ent; entities.
 		def unnormalized
+      document.record_entity_expansion
 			v = value()
 			return nil if v.nil?
 			@unnormalized = Text::unnormalize(v, parent)
Index: test/rexml/test_document.rb
===================================================================
--- test/rexml/test_document.rb	(revision 0)
+++ test/rexml/test_document.rb	(revision 0)
@@ -0,0 +1,42 @@
+require "rexml/document"
+require "test/unit"
+
+class REXML::TestDocument < Test::Unit::TestCase
+  def test_new
+    doc = REXML::Document.new(<<EOF)
+<?xml version="1.0" encoding="UTF-8"?>
+<message>Hello world!</message>
+EOF
+    assert_equal("Hello world!", doc.root.children.first.value)
+  end
+
+  XML_WITH_NESTED_ENTITY = <<EOF
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE member [
+  <!ENTITY a "&b;&b;&b;&b;&b;&b;&b;&b;&b;&b;">
+  <!ENTITY b "&c;&c;&c;&c;&c;&c;&c;&c;&c;&c;">
+  <!ENTITY c "&d;&d;&d;&d;&d;&d;&d;&d;&d;&d;">
+  <!ENTITY d "&e;&e;&e;&e;&e;&e;&e;&e;&e;&e;">
+  <!ENTITY e "&f;&f;&f;&f;&f;&f;&f;&f;&f;&f;">
+  <!ENTITY f "&g;&g;&g;&g;&g;&g;&g;&g;&g;&g;">
+  <!ENTITY g "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx">
+]>
+<member>
+&a;
+</member>
+EOF
+
+  def test_entity_expansion_limit
+    doc = REXML::Document.new(XML_WITH_NESTED_ENTITY)
+    assert_raise(RuntimeError) do
+      doc.root.children.first.value
+    end
+    REXML::Document.entity_expansion_limit = 100
+    assert_equal(100, REXML::Document.entity_expansion_limit)
+    doc = REXML::Document.new(XML_WITH_NESTED_ENTITY)
+    assert_raise(RuntimeError) do
+      doc.root.children.first.value
+    end
+    assert_equal(101, doc.entity_expansion_count)
+  end
+end

Thread

Prev Next

In This Thread

Prev Next