ruby-core

On 2/24/07, Akinori MUSHA <knu@idaemons.org> wrote:

> Please test it out and drop us a report if you find any problem.

The attached patch against the ruby_1_8_6 branch fixes a few compiler
warnings about pointer signedness mismatches when compiling on Mac OS
X.

Attachments (1)

ruby-changes.patch (4.76 KB, text/x-diff)

Index: ext/digest/digest.c
===================================================================
--- ext/digest/digest.c	(revision 11870)
+++ ext/digest/digest.c	(working copy)
@@ -519,7 +519,7 @@
     Data_Get_Struct(self, void, pctx);
 
     StringValue(str);
-    algo->update_func(pctx, RSTRING_PTR(str), RSTRING_LEN(str));
+    algo->update_func(pctx, (unsigned char *)RSTRING_PTR(str), RSTRING_LEN(str));
 
     return self;
 }
@@ -537,7 +537,7 @@
     Data_Get_Struct(self, void, pctx);
 
     str = rb_str_new(0, algo->digest_len);
-    algo->finish_func(pctx, RSTRING_PTR(str));
+    algo->finish_func(pctx, (unsigned char *)RSTRING_PTR(str));
 
     /* avoid potential coredump caused by use of a finished context */
     algo->init_func(pctx);
Index: ext/digest/rmd160/rmd160ossl.c
===================================================================
--- ext/digest/rmd160/rmd160ossl.c	(revision 11870)
+++ ext/digest/rmd160/rmd160ossl.c	(working copy)
@@ -4,5 +4,5 @@
 #include "rmd160ossl.h"
 
 void RMD160_Finish(RMD160_CTX *ctx, char *buf) {
-	RIPEMD160_Final(buf, ctx);
+	RIPEMD160_Final((unsigned char *)buf, ctx);
 }
Index: ext/digest/sha1/sha1ossl.c
===================================================================
--- ext/digest/sha1/sha1ossl.c	(revision 11870)
+++ ext/digest/sha1/sha1ossl.c	(working copy)
@@ -6,5 +6,5 @@
 void
 SHA1_Finish(SHA1_CTX *ctx, char *buf)
 {
-	SHA1_Final(buf, ctx);
+	SHA1_Final((unsigned char *)buf, ctx);
 }
Index: ext/bigdecimal/bigdecimal.c
===================================================================
--- ext/bigdecimal/bigdecimal.c	(revision 11870)
+++ ext/bigdecimal/bigdecimal.c	(working copy)
@@ -332,7 +332,7 @@
     unsigned long m=0;
 
     SafeStringValue(str);
-    pch = RSTRING_PTR(str);
+    pch = (unsigned char *)RSTRING_PTR(str);
     /* First get max prec */
     while((*pch)!=(unsigned char)'\0' && (ch=*pch++)!=(unsigned char)':') {
         if(!ISDIGIT(ch)) {
@@ -341,7 +341,7 @@
         m = m*10 + (unsigned long)(ch-'0');
     }
     if(m>VpBaseFig()) m -= VpBaseFig();
-    GUARD_OBJ(pv,VpNewRbClass(m,pch,self));
+    GUARD_OBJ(pv,VpNewRbClass(m,(char *)pch,self));
     m /= VpBaseFig();
     if(m && pv->MaxPrec>m) pv->MaxPrec = m+1;
     return ToValue(pv);
Index: ext/nkf/nkf.c
===================================================================
--- ext/nkf/nkf.c	(revision 11870)
+++ ext/nkf/nkf.c	(working copy)
@@ -63,7 +63,7 @@
     o_len += incsize;
     rb_str_resize(result, o_len);
     incsize *= 2;
-    output = RSTRING(result)->ptr;
+    output = (unsigned char *)RSTRING(result)->ptr;
   }
   output[output_ctr++] = c;
 
@@ -158,13 +158,13 @@
 
   input_ctr = 0;
   StringValue(src);
-  input = RSTRING(src)->ptr;
+  input = (unsigned char *)RSTRING(src)->ptr;
   i_len = RSTRING(src)->len;
   result = rb_str_new(0, i_len*3 + 10);
   v = result;
 
   output_ctr = 0;
-  output     = RSTRING(result)->ptr;
+  output     = (unsigned char *)RSTRING(result)->ptr;
   o_len      = RSTRING(result)->len;
   *output    = '\0';
 
@@ -213,7 +213,7 @@
   int sequence_counter = 0;
 
   StringValue(src);
-  p = RSTRING(src)->ptr;
+  p = (unsigned char *)RSTRING(src)->ptr;
   pend = p + RSTRING(src)->len;
   if (p == pend) return INT2FIX(_UNKNOWN);
 
@@ -328,7 +328,7 @@
 
   input_ctr = 0;
   StringValue(src);
-  input = RSTRING(src)->ptr;
+  input = (unsigned char *)RSTRING(src)->ptr;
   i_len = RSTRING(src)->len;
 
   if(x0201_f == WISH_TRUE)
Index: regex.c
===================================================================
--- regex.c	(revision 11870)
+++ regex.c	(working copy)
@@ -1014,8 +1014,8 @@
 {
   int mcnt;
   int max = 0;
-  unsigned char *p = start;
-  unsigned char *pend = end;
+  unsigned char *p = (unsigned char *)start;
+  unsigned char *pend = (unsigned char *)end;
   char *must = 0;
 
   if (start == NULL) return 0;
@@ -1029,7 +1029,7 @@
     case exactn:
       mcnt = *p;
       if (mcnt > max) {
-	must = p;
+	must = (char *)p;
 	max = mcnt;
       }
       p += mcnt+1;
@@ -2689,7 +2689,7 @@
       }
     }
 
-    if (slow_match(little, little+llen, big, bend, translate))
+    if (slow_match(little, little+llen, big, bend, (unsigned char *)translate))
       return big - bsave;
 
     big+=mbclen(*big);
@@ -3222,13 +3222,13 @@
     }
     pend = size;
     if (bufp->options & RE_OPTIMIZE_NO_BM) {
-      pos = slow_search(bufp->must+1, len,
-			string+pbeg, pend-pbeg,
-			MAY_TRANSLATE()?translate:0);
+      pos = slow_search((unsigned char *)(bufp->must+1), len,
+			(unsigned char*)(string+pbeg), pend-pbeg,
+			(char *)(MAY_TRANSLATE()?translate:0));
     }
     else {
-      pos = bm_search(bufp->must+1, len,
-		      string+pbeg, pend-pbeg,
+      pos = bm_search((unsigned char *)(bufp->must+1), len,
+		      (unsigned char *)(string+pbeg), pend-pbeg,
 		      bufp->must_skip,
 		      MAY_TRANSLATE()?translate:0);
     }

Thread

Prev Next

In This Thread

Prev Next