Re: [PATCH] Test::Unit shows result even if interrupted

Kouhei Sutou <[e-mail]> writes:

> Hi,
>
> Who is the Test::Unit maintainer?
> I've waited about a year but I haven't been got any response.
>
>
> Thanks,
> --
> kou

But...  You still have to wait through all of the tests that come
*before* the target test.  Isn't the --testcase=PATTERN switch (or
super-convenient --line= in RSpec) what you really want?

Steve

> In <[e-mail]>
>   "[PATCH] Test::Unit shows result even if interrupted" on Sun, 25 Feb 2007 16:07:23 +0900 (JST),
>   Kouhei Sutou <[e-mail]> wrote:
>
>> Hi,
>> 
>> I have a test suite that takes many time to finish all test
>> cases. So, I often stop test runner by Ctrl+C if I find some
>> F/E. And I start debugging to pass the F/E. I can't wait for
>> finishing all test cases. Because I want to change test
>> status to GREEN from RED as soon as possible.
>> 
>> But there is a problem. Test::Unit doesn't show
>> failure/error details when I interrupt test runner.
>> 
>> I hope that Test::Unit shows result even if interrupted by
>> user. We will be able to start debugging before all test
>> cases are finished if Test::Unit supports this feature.
>> 
>> The attached patch is an implementation of this feature.
>> 
>> 
>> # I requested same feature to RSpec too. And RSpec accepted
>> # my request.
>> 
>> 
>> Thanks,
>> --
>> kou
> Index: lib/test/unit/ui/testrunnermediator.rb
> ===================================================================
> --- lib/test/unit/ui/testrunnermediator.rb	(revision 11881)
> +++ lib/test/unit/ui/testrunnermediator.rb	(working copy)
> @@ -34,24 +34,27 @@
>            begin_time = Time.now
>            notify_listeners(RESET, @suite.size)
>            result = create_result
> -          notify_listeners(STARTED, result)
> -          result_listener = result.add_listener(TestResult::CHANGED) do |updated_result|
> -            notify_listeners(TestResult::CHANGED, updated_result)
> -          end
> -          
> -          fault_listener = result.add_listener(TestResult::FAULT) do |fault|
> -            notify_listeners(TestResult::FAULT, fault)
> -          end
> -          
> -          @suite.run(result) do |channel, value|
> -            notify_listeners(channel, value)
> +          begin
> +            notify_listeners(STARTED, result)
> +            result_listener = result.add_listener(TestResult::CHANGED) do |updated_result|
> +              notify_listeners(TestResult::CHANGED, updated_result)
> +            end
> +
> +            fault_listener = result.add_listener(TestResult::FAULT) do |fault|
> +              notify_listeners(TestResult::FAULT, fault)
> +            end
> +
> +            @suite.run(result) do |channel, value|
> +              notify_listeners(channel, value)
> +            end
> +          rescue Interrupt
> +          ensure
> +            result.remove_listener(TestResult::FAULT, fault_listener)
> +            result.remove_listener(TestResult::CHANGED, result_listener)
> +            end_time = Time.now
> +            elapsed_time = end_time - begin_time
> +            notify_listeners(FINISHED, elapsed_time) #"Finished in #{elapsed_time} seconds.")
>            end
> -          
> -          result.remove_listener(TestResult::FAULT, fault_listener)
> -          result.remove_listener(TestResult::CHANGED, result_listener)
> -          end_time = Time.now
> -          elapsed_time = end_time - begin_time
> -          notify_listeners(FINISHED, elapsed_time) #"Finished in #{elapsed_time} seconds.")
>            return result
>          end
>