From: Marcus Rueckert <mrueckert@...>
Date: 2007-02-22T04:46:58+09:00
Subject: Re: [PATCH] vendor_ruby support

hi,

Thanks for looking into the patch

On 2007-02-22 04:16:04 +0900, Nobuyoshi Nakada wrote:
> At Wed, 21 Feb 2007 23:57:05 +0900,
> Marcus Rueckert wrote in [ruby-core:10387]:
> > +VENDOR_DIR="`eval \"echo ${vendordir}\"`"
> 
> This results empty on NetBSD.

oh. as it was included in macports i thought it will work on bsds. I
will remember it for further patches.

> > +case "$target_os" in
> > +  cygwin*|mingw*|*djgpp*|os2_emx*)
> 
> os2-emx, not os2_emx.

i guess they copied it from somewhere and i just kept it. :)

> > Index: mkconfig.rb
> > +  if defined?(VENDOR_SPECIFIC) && VENDOR_SPECIFIC
> > + 	CONFIG["sitearch"] = CONFIG["vendorarch"]
> > + 	CONFIG["sitedir"] = CONFIG["vendordir"]
> > + 	CONFIG["sitelibdir"] = CONFIG["vendorlibdir"]
> > + 	CONFIG["sitearchdir"] = CONFIG["vendorarchdir"]
> > +  end
> 
> It should be done in mkmf.rb.

wouldnt it mean we need to duplicate the handling in mkrf than?
so far the patch didnt require any changes to mkrf.

> > Index: lib/mkmf.rb
> > +int #{func}();
> > +/*top*/
> > +int main() { return 0; }
> > +int t() { #{func}(); return 0; }
> > +SRC
> 
> This change seems harmful.

ok. we can remove the chunk i guess.

> > Index: instruby.rb
> >  archlibdir = CONFIG["archdir"]
> >  sitelibdir = CONFIG["sitelibdir"]
> >  sitearchlibdir = CONFIG["sitearchdir"]
> > +vendorlibdir = with_destdir(CONFIG["vendorlibdir"])
> > +vendorarchlibdir = with_destdir(CONFIG["vendorarchdir"])
> 
> Wrong usage of with_destdir.

ok.

> And we have to take care of {bcc32,win{32,ce}}/Makefile.sub too.

i will try to look into those. but i dont have experience with those.

thanks again for looking into the patch. :)

    darix

-- 
          openSUSE - SUSE Linux is my linux
              openSUSE is good for you
                  www.opensuse.org