[#10193] String.ord — David Flanagan <david@...>

Hi,

41 messages 2007/02/05
[#10197] Re: String.ord — Yukihiro Matsumoto <matz@...> 2007/02/06

Hi,

[#10198] Re: String.ord — David Flanagan <david@...> 2007/02/06

Yukihiro Matsumoto wrote:

[#10199] Re: String.ord — Daniel Berger <djberg96@...> 2007/02/06

David Flanagan wrote:

[#10200] Re: String.ord — David Flanagan <david@...> 2007/02/06

Daniel Berger wrote:

[#10208] Re: String.ord — "Nikolai Weibull" <now@...> 2007/02/06

On 2/6/07, David Flanagan <david@davidflanagan.com> wrote:

[#10213] Re: String.ord — David Flanagan <david@...> 2007/02/06

Nikolai Weibull wrote:

[#10215] Re: String.ord — "Nikolai Weibull" <now@...> 2007/02/06

On 2/6/07, David Flanagan <david@davidflanagan.com> wrote:

[#10216] Re: String.ord — David Flanagan <david@...> 2007/02/07

Nikolai Weibull wrote:

[#10288] Socket library should support abstract unix sockets — <noreply@...>

Bugs item #8597, was opened at 2007-02-13 16:10

12 messages 2007/02/13

[#10321] File.basename fails on Windows root paths — <noreply@...>

Bugs item #8676, was opened at 2007-02-15 10:09

11 messages 2007/02/15

[#10323] Trouble with xmlrpc — James Edward Gray II <james@...>

Some of the Ruby code used by TextMate makes use of xmlrpc/

31 messages 2007/02/15
[#10324] Re: Trouble with xmlrpc — "Berger, Daniel" <Daniel.Berger@...> 2007/02/15

> -----Original Message-----

[#10326] Re: Trouble with xmlrpc — James Edward Gray II <james@...> 2007/02/15

On Feb 15, 2007, at 1:29 PM, Berger, Daniel wrote:

[#10342] Re: Trouble with xmlrpc — James Edward Gray II <james@...> 2007/02/16

While I am complaining about xmlrpc, we have another issue. It's

[#10343] Re: Trouble with xmlrpc — Alex Young <alex@...> 2007/02/16

James Edward Gray II wrote:

[#10344] Re: Trouble with xmlrpc — James Edward Gray II <james@...> 2007/02/16

On Feb 16, 2007, at 12:08 PM, Alex Young wrote:

Re: Trouble with xmlrpc

From: James Edward Gray II <james@...>
Date: 2007-02-16 13:49:56 UTC
List: ruby-core #10337
On Feb 15, 2007, at 1:33 PM, James Edward Gray II wrote:

> On Feb 15, 2007, at 1:29 PM, Berger, Daniel wrote:
>
>>> -----Original Message-----
>>> From: James Edward Gray II [mailto:james@grayproductions.net]
>>> Sent: Thursday, February 15, 2007 12:19 PM
>>> To: Ruby Core
>>> Subject: Trouble with xmlrpc
>>>
>>>
>>> Some of the Ruby code used by TextMate makes use of xmlrpc/
>>> client.rb.  We are now getting bug reports from users and have
>>> tracked the issue back to this bit of code in that file:
>>>
>>> http://pastie.textmate.org/39421
>>>
>>> This code throws an error if the response does not have a Content-
>>> Length header, but our understanding is that this header is not
>>> mandatory.  Could anyone please explain to me why this limitation is
>>> in place?
>>
>> My *guess* is that this:
>>
>> elsif expected.to_i != data.size and resp["Transfer-Encoding"].nil?
>>
>> Should be:
>>
>> elsif expected != '<unknown>' and expected.to_i != data.size and
>> resp["Transfer-Encoding"].nil?
>
> That makes a lot more sense to me, since the code goes through the  
> trouble of setting "<unknown>" in the first place.

Since no one seems to be claiming this is expected behavior, can we  
please fix it?

Below I will provide a patch against the ruby_1_8 branch.  It should  
also be applied to trunk and I can provide that patch if needed.

CHANGELOG:

Making the Content-Length parameter optional for responses in xmlrpc/ 
client.rb.

James Edward Gray II

Attachments (1)

xmlrpc_client_fix.patch (623 Bytes, text/x-diff)
Index: lib/xmlrpc/client.rb
===================================================================
--- lib/xmlrpc/client.rb	(revision 11763)
+++ lib/xmlrpc/client.rb	(working copy)
@@ -558,7 +558,7 @@
       expected = resp["Content-Length"] || "<unknown>"
       if data.nil? or data.size == 0 
         raise "Wrong size. Was #{data.size}, should be #{expected}" 
-      elsif expected.to_i != data.size and resp["Transfer-Encoding"].nil?
+      elsif expected != "<unknown>" and expected.to_i != data.size and resp["Transfer-Encoding"].nil?
         raise "Wrong size. Was #{data.size}, should be #{expected}"
       end
 

In This Thread