From: Robert Dober <robert.dober@...>
Date: 2007-02-01T16:21:29+09:00
Subject: Re: How to submit patch for RCR Integer#pred ?

------=_Part_817_9890131.1170314487904
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On 2/1/07, Yukihiro Matsumoto <matz@ruby-lang.org> wrote:
>
> Hi,
>
> In message "Re: How to submit patch for RCR Integer#pred ?"
>     on Thu, 1 Feb 2007 05:59:04 +0900, "Robert Dober" <
> robert.dober@gmail.com> writes:
>
> |This is of course very easy to implement and I thought I do it as this is
> |not a task for the more talented and experienced hackers.
> |So I just wrote the patch against YARV and I realize that I have no idea
> how
> |to submit it.
>
> It's already checked in for YARV.  In general, process of submitting
> patches are following:


Wow thanks

  * make a modification against trunk.  Even if you want to add your
>     proposed feature to stable (1.8), it needs to be proven in the
>     trunk.  If your modification is a bug fix for 1.8, you have to use
>     the latest 1.8 source tree.
>
>   * make your patch by "diff -u".
>
>   * post your patch here in ruby-core, preferably with a ChangeLog
>     entry to describe the patch.
>
>   * you will get approval to commit if you are a committer, otherwise
>     one of our committers (perhaps me) will submit the patch if there
>     is no problem for the patch.
>
>                                                         matz.
>
> Ok noted, thank you
Cheers
Robert


-- 
"The best way to predict the future is to invent it."
- Alan Kay

------=_Part_817_9890131.1170314487904
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

<br><br><div><span class="gmail_quote">On 2/1/07, <b class="gmail_sendername">Yukihiro Matsumoto</b> &lt;<a href="mailto:matz@ruby-lang.org">matz@ruby-lang.org</a>&gt; wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br><br>In message &quot;Re: How to submit patch for RCR Integer#pred ?&quot;<br>&nbsp;&nbsp;&nbsp;&nbsp;on Thu, 1 Feb 2007 05:59:04 +0900, &quot;Robert Dober&quot; &lt;<a href="mailto:robert.dober@gmail.com">robert.dober@gmail.com</a>&gt; writes:
<br><br>|This is of course very easy to implement and I thought I do it as this is<br>|not a task for the more talented and experienced hackers.<br>|So I just wrote the patch against YARV and I realize that I have no idea how
<br>|to submit it.<br><br>It&#39;s already checked in for YARV.&nbsp;&nbsp;In general, process of submitting<br>patches are following:</blockquote><div><br>Wow thanks <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
&nbsp;&nbsp;* make a modification against trunk.&nbsp;&nbsp;Even if you want to add your<br>&nbsp;&nbsp;&nbsp;&nbsp;proposed feature to stable (1.8), it needs to be proven in the<br>&nbsp;&nbsp;&nbsp;&nbsp;trunk.&nbsp;&nbsp;If your modification is a bug fix for 1.8, you have to use<br>&nbsp;&nbsp;&nbsp;&nbsp;the latest 
1.8 source tree.<br><br>&nbsp;&nbsp;* make your patch by &quot;diff -u&quot;.<br><br>&nbsp;&nbsp;* post your patch here in ruby-core, preferably with a ChangeLog<br>&nbsp;&nbsp;&nbsp;&nbsp;entry to describe the patch.<br><br>&nbsp;&nbsp;* you will get approval to commit if you are a committer, otherwise
<br>&nbsp;&nbsp;&nbsp;&nbsp;one of our committers (perhaps me) will submit the patch if there<br>&nbsp;&nbsp;&nbsp;&nbsp;is no problem for the patch.<br><br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;matz.<br><br></blockquote></div>Ok noted, thank you
<br>Cheers<br>Robert<br><br clear="all"><br>-- <br>&quot;The best way to predict the future is to invent it.&quot; <br>- Alan Kay

------=_Part_817_9890131.1170314487904--