[ruby-dev:19870] Re: [Oniguruma] Version 1.8.4

In article <[e-mail]>,
  [e-mail] (Yukihiro Matsumoto) writes:

> rb_warn()というRuby固有の関数を直接呼ぶのは抵抗があるので、
> 少々細工してから取り込むことにします。

すいません。あれだと

  /[0-[]/

のように range の最後に [ がきた時に警告しないのでベースにするのは次の
にしてください。

Index: regex.c
===================================================================
RCS file: /src/ruby/regex.c,v
retrieving revision 1.80
diff -u -r1.80 regex.c
--- regex.c	24 Jan 2003 09:18:04 -0000	1.80
+++ regex.c	21 Mar 2003 14:23:01 -0000
@@ -1464,6 +1464,7 @@
 	  if (p == p0 + 1) {
 	    if (p == pend)
 	      FREE_AND_RETURN(stackb, "invalid regular expression; empty character class");
+            rb_warn("character class has `]' without escape");
 	  }
 	  else 
 	    /* Stop if this isn't merely a ] inside a bracket
@@ -1481,6 +1482,9 @@
 	}
 	had_char_class = 0;
 
+	if (c == '-' || (c == '[' && *p != ':'))
+          rb_warn("character class has `%c' without escape", c);
+
 	/* \ escapes characters when inside [...].  */
 	if (c == '\\') {
 	  PATFETCH_RAW(c);
@@ -1678,6 +1682,7 @@
 	    c1++;
 	    while (c1--)    
 	      PATUNFETCH;
+            rb_warn("character class has `[' without escape");
 	    SET_LIST_BIT(TRANSLATE_P()?translate['[']:'[');
 	    SET_LIST_BIT(TRANSLATE_P()?translate[':']:':');
 	    had_char_class = 0;

それはそれとして、これを当てると(静的なリテラルとして書いてあるぶんに
ついては) ruby -c でチェックできるわけですが、添付されてるものに関して
だけでもこのくらいあるようです。うぅむ。ちょっとやりすぎかも?

ext/extmk.rb:130: warning: character class has `-' without escape
ext/tk/lib/tk.rb:608: warning: character class has `]' without escape
ext/tk/lib/tk.rb:608: warning: character class has `[' without escape
ext/tk/lib/tk.rb:623: warning: character class has `]' without escape
ext/tk/lib/tk.rb:623: warning: character class has `[' without escape
ext/tk/lib/tk.rb:1182: warning: character class has `]' without escape
ext/tk/lib/tk.rb:1182: warning: character class has `[' without escape
ext/tk/lib/tk.rb:1186: warning: character class has `]' without escape
ext/tk/lib/tk.rb:1186: warning: character class has `[' without escape
ext/tk/lib/tk.rb:1189: warning: character class has `]' without escape
ext/tk/lib/tk.rb:1189: warning: character class has `[' without escape
ext/tk/lib/tk.rb:1217: warning: character class has `]' without escape
ext/tk/lib/tk.rb:1217: warning: character class has `[' without escape
ext/tk/lib/tk.rb:1229: warning: character class has `]' without escape
ext/tk/lib/tk.rb:1229: warning: character class has `[' without escape
ext/tk/lib/tk.rb:1234: warning: character class has `]' without escape
ext/tk/lib/tk.rb:1234: warning: character class has `[' without escape
ext/tk/lib/tk.rb:1441: warning: character class has `]' without escape
ext/tk/lib/tk.rb:1441: warning: character class has `[' without escape
instruby.rb:28: warning: character class has `-' without escape
lib/benchmark.rb:580: warning: character class has `-' without escape
lib/benchmark.rb:581: warning: character class has `-' without escape
lib/benchmark.rb:582: warning: character class has `-' without escape
lib/benchmark.rb:583: warning: character class has `-' without escape
lib/benchmark.rb:584: warning: character class has `-' without escape
lib/benchmark.rb:585: warning: character class has `-' without escape
lib/benchmark.rb:586: warning: character class has `-' without escape
lib/cgi.rb:239: warning: character class has `-' without escape
lib/date/format.rb:83: warning: character class has `-' without escape
lib/date/format.rb:166: warning: character class has `-' without escape
lib/date/format.rb:176: warning: character class has `-' without escape
lib/date/format.rb:230: warning: character class has `-' without escape
lib/date/format.rb:252: warning: character class has `-' without escape
lib/date/format.rb:311: warning: character class has `-' without escape
lib/date/format.rb:382: warning: character class has `-' without escape
lib/date/format.rb:382: warning: character class has `-' without escape
lib/date/format.rb:447: warning: character class has `-' without escape
lib/debug.rb:428: warning: character class has `-' without escape
lib/getoptlong.rb:183: warning: character class has `-' without escape
lib/irb/ruby-lex.rb:951: warning: character class has `-' without escape
lib/jcode.rb:12: warning: character class has `]' without escape
lib/jcode.rb:12: warning: character class has `[' without escape
lib/jcode.rb:12: warning: character class has `]' without escape
lib/jcode.rb:12: warning: character class has `[' without escape
lib/optparse.rb:968: warning: character class has `]' without escape
lib/optparse.rb:968: warning: character class has `[' without escape
lib/optparse.rb:978: warning: character class has `]' without escape
lib/optparse.rb:978: warning: character class has `[' without escape
lib/optparse.rb:990: warning: character class has `]' without escape
lib/optparse.rb:990: warning: character class has `[' without escape
lib/time.rb:72: warning: character class has `-' without escape
lib/time.rb:74: warning: character class has `-' without escape
-- 
[田中 哲][たなか あきら][Tanaka Akira]