[#33640] [Ruby 1.9-Bug#4136][Open] Enumerable#reject should not inherit the receiver's instance variables — Hiro Asari <redmine@...>

Bug #4136: Enumerable#reject should not inherit the receiver's instance variables

10 messages 2010/12/08

[#33667] [Ruby 1.9-Bug#4149][Open] Documentation submission: syslog standard library — mathew murphy <redmine@...>

Bug #4149: Documentation submission: syslog standard library

11 messages 2010/12/10

[#33683] [feature:trunk] Enumerable#categorize — Tanaka Akira <akr@...>

Hi.

14 messages 2010/12/12
[#33684] Re: [feature:trunk] Enumerable#categorize — "Martin J. Dst" <duerst@...> 2010/12/12

[#33687] Towards a standardized AST for Ruby code — Magnus Holm <judofyr@...>

Hey folks,

23 messages 2010/12/12
[#33688] Re: Towards a standardized AST for Ruby code — Charles Oliver Nutter <headius@...> 2010/12/12

On Sun, Dec 12, 2010 at 9:55 AM, Magnus Holm <judofyr@gmail.com> wrote:

[#33689] Re: Towards a standardized AST for Ruby code — "Haase, Konstantin" <Konstantin.Haase@...> 2010/12/12

On Dec 12, 2010, at 17:46 , Charles Oliver Nutter wrote:

[#33763] [Ruby 1.9-Bug#4168][Open] WeakRef is unsafe to use in Ruby 1.9 — Brian Durand <redmine@...>

Bug #4168: WeakRef is unsafe to use in Ruby 1.9

43 messages 2010/12/17

[#33815] trunk warnflags build issue with curb 0.7.9? — Jon <jon.forums@...>

As this may turn out to be a 3rd party issue rather than a bug, I'd like some feedback.

11 messages 2010/12/22

[#33833] Ruby 1.9.2 is going to be released — "Yuki Sonoda (Yugui)" <yugui@...>

-----BEGIN PGP SIGNED MESSAGE-----

15 messages 2010/12/23

[#33846] [Ruby 1.9-Feature#4197][Open] Improvement of the benchmark library — Benoit Daloze <redmine@...>

Feature #4197: Improvement of the benchmark library

15 messages 2010/12/23

[#33910] [Ruby 1.9-Feature#4211][Open] Converting the Ruby and C API documentation to YARD syntax — Loren Segal <redmine@...>

Feature #4211: Converting the Ruby and C API documentation to YARD syntax

10 messages 2010/12/26

[#33923] [Ruby 1.9-Bug#4214][Open] Fiddle::WINDOWS == false on Windows — Jon Forums <redmine@...>

Bug #4214: Fiddle::WINDOWS == false on Windows

15 messages 2010/12/27

[ruby-core:33977] [Ruby 1.9-Bug#4214] Fiddle::WINDOWS == false on Windows

From: Jon Forums <redmine@...>
Date: 2010-12-28 21:39:26 UTC
List: ruby-core #33977
Issue #4214 has been updated by Jon Forums.

File 0001-windows-macros-for-dl-n-fiddle.patch added

Attached patch gives the following results on Win7 Ultimate 32-bit with similar results on Arch Linux except on Arch the results were "123 tests, 229 assertions, 0 failures, 0 errors, 0 skips"

I didn't mod DL's extconf.rb as I've not looked over DL's code enough to feel comfortable doing so. 

C:\projects\rubyinstaller-git\sandbox\ruby19_build>make test-all TESTS="fiddle dl"
./miniruby.exe -I../../../../Users/Jon/Documents/RubyDev/ruby-git/lib -I.ext/common  ../../../../Users/Jon/Documents/RubyDev/ruby-git/tool/runruby.rb --extout=.ext
 -- "../../../../Users/Jon/Documents/RubyDev/ruby-git/test/runner.rb" fiddle dl
Run options:

# Running tests:

....................................................................S....SS..........S......................................

Finished tests in 0.126516s, 980.1132 tests/s, 1770.5270 assertions/s.

  1) Skipped:
test_sinf(DL::TestFunc) [C:/Users/Jon/Documents/RubyDev/ruby-git/test/dl/test_func.rb:29]:
libm may not have sinf()

  2) Skipped:
test_DEFAULT(DL::TestHandle) [C:/Users/Jon/Documents/RubyDev/ruby-git/test/dl/test_handle.rb:169]:
DL::Handle::DEFAULT is not supported

  3) Skipped:
test_NEXT(DL::TestHandle) [C:/Users/Jon/Documents/RubyDev/ruby-git/test/dl/test_handle.rb:136]:
DL::Handle::NEXT is not supported

  4) Skipped:
test_static_sym(DL::TestHandle) [C:/Users/Jon/Documents/RubyDev/ruby-git/test/dl/test_handle.rb:25]:
DL::Handle.sym is not supported

124 tests, 224 assertions, 0 failures, 0 errors, 4 skips
----------------------------------------
http://redmine.ruby-lang.org/issues/show/4214

----------------------------------------
http://redmine.ruby-lang.org

Attachments (1)

diff --git a/ext/dl/cfunc.c b/ext/dl/cfunc.c
index 33ac784..f13ff34 100644
--- a/ext/dl/cfunc.c
+++ b/ext/dl/cfunc.c
@@ -23,7 +23,7 @@ rb_dl_set_last_error(VALUE self, VALUE val)
     return Qnil;
 }
 
-#if defined(HAVE_WINDOWS_H)
+#if defined(_WIN32)
 #include <windows.h>
 static ID id_win32_last_error;
 
@@ -578,7 +578,7 @@ rb_dlcfunc_call(VALUE self, VALUE ary)
     }
 
     rb_dl_set_last_error(self, INT2NUM(errno));
-#if defined(HAVE_WINDOWS_H)
+#if defined(_WIN32)
     rb_dl_set_win32_last_error(self, INT2NUM(GetLastError()));
 #endif
 
@@ -607,13 +607,13 @@ void
 Init_dlcfunc(void)
 {
     id_last_error = rb_intern("__DL2_LAST_ERROR__");
-#if defined(HAVE_WINDOWS_H)
+#if defined(_WIN32)
     id_win32_last_error = rb_intern("__DL2_WIN32_LAST_ERROR__");
 #endif
     rb_cDLCFunc = rb_define_class_under(rb_mDL, "CFunc", rb_cObject);
     rb_define_alloc_func(rb_cDLCFunc, rb_dlcfunc_s_allocate);
     rb_define_module_function(rb_cDLCFunc, "last_error", rb_dl_get_last_error, 0);
-#if defined(HAVE_WINDOWS_H)
+#if defined(_WIN32)
     rb_define_module_function(rb_cDLCFunc, "win32_last_error", rb_dl_get_win32_last_error, 0);
 #endif
     rb_define_method(rb_cDLCFunc, "initialize", rb_dlcfunc_initialize, -1);
diff --git a/ext/dl/dl.h b/ext/dl/dl.h
index 2fa330f..2b3b1f8 100644
--- a/ext/dl/dl.h
+++ b/ext/dl/dl.h
@@ -20,7 +20,7 @@
 #define RTLD_NOW 0
 #endif
 #else
-# if defined(HAVE_WINDOWS_H)
+# if defined(_WIN32)
 #   include <windows.h>
 #   define dlopen(name,flag) ((void*)LoadLibrary(name))
 #   define dlerror() strerror(rb_w32_map_errno(GetLastError()))
diff --git a/ext/dl/handle.c b/ext/dl/handle.c
index ed042e1..6fc771c 100644
--- a/ext/dl/handle.c
+++ b/ext/dl/handle.c
@@ -7,7 +7,7 @@
 
 VALUE rb_cDLHandle;
 
-#ifdef HAVE_WINDOWS_H
+#ifdef _WIN32
 # ifndef _WIN32_WCE
 static void *
 w32_coredll(void)
@@ -142,7 +142,7 @@ rb_dlhandle_initialize(int argc, VALUE argv[], VALUE self)
 
     rb_secure(2);
 
-#if defined(HAVE_WINDOWS_H)
+#if defined(_WIN32)
     if( !clib ){
 	HANDLE rb_libruby_handle(void);
 	ptr = rb_libruby_handle();
diff --git a/ext/fiddle/extconf.rb b/ext/fiddle/extconf.rb
index 3dcd914..03b0ac2 100644
--- a/ext/fiddle/extconf.rb
+++ b/ext/fiddle/extconf.rb
@@ -18,7 +18,6 @@ unless have_library('ffi') || have_library('libffi')
 end
 
 have_header 'sys/mman.h'
-have_header 'windows.h'
 
 create_makefile 'fiddle'
 
diff --git a/ext/fiddle/fiddle.c b/ext/fiddle/fiddle.c
index 78e21c5..2580ac0 100644
--- a/ext/fiddle/fiddle.c
+++ b/ext/fiddle/fiddle.c
@@ -18,7 +18,7 @@ void Init_fiddle()
     rb_define_const(mFiddle, "TYPE_FLOAT",     INT2NUM(TYPE_FLOAT));
     rb_define_const(mFiddle, "TYPE_DOUBLE",    INT2NUM(TYPE_DOUBLE));
 
-#if defined(HAVE_WINDOWS_H)
+#if defined(_WIN32)
     rb_define_const(mFiddle, "WINDOWS", Qtrue);
 #else
     rb_define_const(mFiddle, "WINDOWS", Qfalse);
diff --git a/ext/fiddle/fiddle.h b/ext/fiddle/fiddle.h
index 4418faf..7165969 100644
--- a/ext/fiddle/fiddle.h
+++ b/ext/fiddle/fiddle.h
@@ -4,7 +4,7 @@
 #include <ruby.h>
 #include <errno.h>
 
-#if defined(HAVE_WINDOWS_H)
+#if defined(_WIN32)
 #include <windows.h>
 #endif
 
diff --git a/ext/fiddle/function.c b/ext/fiddle/function.c
index ff18595..911c9b8 100644
--- a/ext/fiddle/function.c
+++ b/ext/fiddle/function.c
@@ -125,7 +125,7 @@ function_call(int argc, VALUE argv[], VALUE self)
     ffi_call(cif, NUM2PTR(rb_Integer(cfunc)), &retval, values);
 
     rb_funcall(mFiddle, rb_intern("last_error="), 1, INT2NUM(errno));
-#if defined(HAVE_WINDOWS_H)
+#if defined(_WIN32)
     rb_funcall(mFiddle, rb_intern("win32_last_error="), 1, INT2NUM(errno));
 #endif
 

In This Thread

Prev Next