From: Benoit Daloze <redmine@...>
Date: 2011-01-27T01:06:06+09:00
Subject: [ruby-core:34873] [Ruby 1.9-Feature#4197] Improvement of the benchmark library

Issue #4197 has been updated by Benoit Daloze.


Hi,

> Koichi said the lib is not his, so I reviewed it.

Thank you.

> I almost accept your patch except following:
>
>> 4291a26b94a63e3066fe
>
> Tests for MRI should use test/unit.

I thought minitest/spec were fine, as it is in the standard library (and the fact test/unit is now a compatibility layer using minitest/unit).
fiddle, minitest, net/smtp, psych, rdoc and rubygems use minitest (according to $ grep -r minitest test).
But only minitest/spec's tests use minitest/spec.

I also understood in [ruby-core:32280], that minitest/spec was accepted (but not rspec/mspec of course, because they are not bundled).

I can change to (mini)test/unit if you want.

> See also test files in test directory.

Do you mean another file than test/benchmark/test_benchmark.rb ?
I included that test in mine, as I thought it would be better to merge all tests together.
(The code is not so similar as there is no assert_nothing_raised in minitest)

>> f20763674b732b2734f9
>
> This introduces API change.
> Yeah, the change won't be a problem, but the rdoc must describe about its return value.
> attr_reader :list also should have the rdoc.

Sorry, I forgot about it.
It is fixed in 227034b9 lib/benchmark: document the return value of #benchmark and the :list attribute in Report

P.S.:
Git sha are not so handy to describe a commit, maybe the description is better (especially if the history is rewritten).

May I assign to you further benchmark issues ?
----------------------------------------
http://redmine.ruby-lang.org/issues/show/4197

----------------------------------------
http://redmine.ruby-lang.org