[#33640] [Ruby 1.9-Bug#4136][Open] Enumerable#reject should not inherit the receiver's instance variables — Hiro Asari <redmine@...>

Bug #4136: Enumerable#reject should not inherit the receiver's instance variables

10 messages 2010/12/08

[#33667] [Ruby 1.9-Bug#4149][Open] Documentation submission: syslog standard library — mathew murphy <redmine@...>

Bug #4149: Documentation submission: syslog standard library

11 messages 2010/12/10

[#33683] [feature:trunk] Enumerable#categorize — Tanaka Akira <akr@...>

Hi.

14 messages 2010/12/12
[#33684] Re: [feature:trunk] Enumerable#categorize — "Martin J. Dst" <duerst@...> 2010/12/12

[#33687] Towards a standardized AST for Ruby code — Magnus Holm <judofyr@...>

Hey folks,

23 messages 2010/12/12
[#33688] Re: Towards a standardized AST for Ruby code — Charles Oliver Nutter <headius@...> 2010/12/12

On Sun, Dec 12, 2010 at 9:55 AM, Magnus Holm <judofyr@gmail.com> wrote:

[#33689] Re: Towards a standardized AST for Ruby code — "Haase, Konstantin" <Konstantin.Haase@...> 2010/12/12

On Dec 12, 2010, at 17:46 , Charles Oliver Nutter wrote:

[#33763] [Ruby 1.9-Bug#4168][Open] WeakRef is unsafe to use in Ruby 1.9 — Brian Durand <redmine@...>

Bug #4168: WeakRef is unsafe to use in Ruby 1.9

43 messages 2010/12/17

[#33815] trunk warnflags build issue with curb 0.7.9? — Jon <jon.forums@...>

As this may turn out to be a 3rd party issue rather than a bug, I'd like some feedback.

11 messages 2010/12/22

[#33833] Ruby 1.9.2 is going to be released — "Yuki Sonoda (Yugui)" <yugui@...>

-----BEGIN PGP SIGNED MESSAGE-----

15 messages 2010/12/23

[#33846] [Ruby 1.9-Feature#4197][Open] Improvement of the benchmark library — Benoit Daloze <redmine@...>

Feature #4197: Improvement of the benchmark library

15 messages 2010/12/23

[#33910] [Ruby 1.9-Feature#4211][Open] Converting the Ruby and C API documentation to YARD syntax — Loren Segal <redmine@...>

Feature #4211: Converting the Ruby and C API documentation to YARD syntax

10 messages 2010/12/26

[#33923] [Ruby 1.9-Bug#4214][Open] Fiddle::WINDOWS == false on Windows — Jon Forums <redmine@...>

Bug #4214: Fiddle::WINDOWS == false on Windows

15 messages 2010/12/27

[ruby-core:33872] Bug in Webrick httprequest.rb using multiple proxies and fix

From: Kasper Johansen <k@...>
Date: 2010-12-25 10:29:20 UTC
List: ruby-core #33872
Hi.

This is my first post to this mailing list, so please tell me, if I 
posted this the wrong place, or I in any other way should do something 
different.

I have been playing around with Webrick for some time now, and decided 
to set up a virtual machine with a hosted webrick based application.

For every request, the request goes through two Apache proxies because 
of lack of IP adresses. The forwarded hostname is therefore split by 
commas like this:

Host= domain.com, someotherdomainoorip.com


Webrick doesnt handle this well. It looks like it only supports one 
single forwarded hostname.

This can however easily be fixed by changing like 291 in httprequest.rb 
from:

host, port = @forwarded_host, @forwarded_port

To:

host, port = @forwarded_host.split(",")[0].strip, @forwarded_port



If not, Webrick will not handle the request and raise an error.


My fix may be more than a hack than a fix, but for now it works and 
makes Webrick actually handle the request instead of crashing. I have 
attached a .diff I made with Subversion.


Thank you for a great programming language.


-- 
Kasper Johansen

Attachments (1)

Index: lib/webrick/httprequest.rb
===================================================================
--- lib/webrick/httprequest.rb	(revision 30363)
+++ lib/webrick/httprequest.rb	(working copy)
@@ -288,7 +288,7 @@
       uri = URI::parse(str)
       return uri if uri.absolute?
       if @forwarded_host
-        host, port = @forwarded_host, @forwarded_port
+        host, port = @forwarded_host.split(",")[0].strip, @forwarded_port
       elsif self["host"]
         pattern = /\A(#{URI::REGEXP::PATTERN::HOST})(?::(\d+))?\z/n
         host, port = *self['host'].scan(pattern)[0]

In This Thread

Prev Next