[ruby-core:35121] [Ruby 1.9-Feature#4197] Improvement of the benchmark library

Issue #4197 has been updated by Benoit Daloze.


Hi,
On 6 February 2011 03:07, Nobuyoshi Nakada wrote:
> Hi,
>
> A library should not leave such globally shared states changed.

I know, that is why I prefer to use IO#flush in libraries.

> `ensure' clause does not affect the return value.
> So tap trick is not needed here.

My mistake, I did not know `ensure' clause preserve the return value.
That's definitely handful.

I guess then the patch is fine.

Tomoyuki: Please commit it (if you want), that will clean that part until I work on it.

>> On IO#sync's subject, I thought once it would be nice to have a block form of IO#sync, which could use ensure.
>
> It's another story, please file new ticket.

I now think it is not a good idea, giving it is probably best not to use IO#sync in a library.
----------------------------------------
http://redmine.ruby-lang.org/issues/show/4197

----------------------------------------
http://redmine.ruby-lang.org