From: Nobuyoshi Nakada <nobu@...>
Date: 2010-12-23T10:36:58+09:00
Subject: [ruby-core:33821] Re: trunk warnflags build issue with curb 0.7.9?

Hi,

At Thu, 23 Dec 2010 03:29:00 +0900,
Jon wrote in [ruby-core:33815]:
> As this may turn out to be a 3rd party issue rather than a bug, I'd like some feedback.

It's a bug in curb.

> compiling curb_postfield.c
> curb_postfield.c: In functioon 'ruby_curl_postfield_to_str':
> curb_postfield.c:446:5: error: ISO C90 forbids mixed declarations and code

I think the error message explains it completely.

> # curb_postfield.c:446
>   char *tmpchrs = curl_escape(StringValuePtr(name), (int)RSTRING_LEN(name));

> Does core consider the above code snippets to be incorrect?

Definitely incorrect.

-- 
Nobu Nakada