From: Aaron Patterson <aaron@...>
Date: 2010-12-25T06:32:14+09:00
Subject: [ruby-core:33858] Re: [Ruby 1.9-Feature#4183][Open] [ext/openssl] Timestamp support


--BOKacYhQ+x31HxR3
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 22, 2010 at 03:19:12AM +0900, Martin Bosslet wrote:
> Feature #4183: [ext/openssl] Timestamp support
> http://redmine.ruby-lang.org/issues/show/4183
>=20
> Author: Martin Bosslet
> Status: Open, Priority: Normal
> Category: ext, Target version: 1.9.2
>=20
> Hi,
>=20
> I'd like to propose the attached code to support timestamp creation and v=
erification in ext/openssl under a new module OpenSSL::Timestamp. It comes =
also with various tests and rDoc documentation. Since OpenSSL only supports=
 timestamps beginning with OpenSSL 1.0, the entire code is in #if brackets =
and the module is defined only for OpenSSL versions >=3D 1.0.=20

I think this is good functionality to add.

The patch seems good.  I noticed some code that is not necessary though.
You can remove these lines:

    /*
     * Creates a Factory.
     *
     * call-seq:
     *       OpenSSL::Timestamp::Factory.new    -> Factory
     */
    static VALUE
    ossl_tsfac_initialize(VALUE self)
    {
        return self;
    }

    rb_define_method(cTimestampFactory, "initialize", ossl_tsfac_initialize=
, 0);

and everything will Just Work=E2=84=A2.

This patch is really long, so if nobody objects after a week or two,
I'll apply.

--=20
Aaron Patterson
http://tenderlovemaking.com/

--BOKacYhQ+x31HxR3
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)

iQEcBAEBAgAGBQJNFRFMAAoJEJUxcLy0/6/G6cAIAID0BGsEOsDYarve/nfXwfy5
mk9ENDsI3qWEfA+keefpZHFlY5O4+M3Z6Xx6e8aOclTJ8qUOGcViDktNZLcpHtT6
dWufZLICbqCIByA90NteyIZb0TATwZ6o69FGzM1UeDOc7uS6zvSi486XU+BWyunt
nO0Do5sYIZlkBT1SbyuE6qKzx/Eo/YPdJUsD2eQDlZhLdHgOTYdknJ41fnQ06uY8
oq/H+6akdthLNHsKtJqxoUtgpgyImEBhVU1xWizR9WOUWWAO6xen/sY/SqOK/iON
FrJZn72yg84SR7HAPEG1dxEcryrXc9nFPH3IK/ZarZoEkbKz8OIL7j/DQswJxKA=
=nPL0
-----END PGP SIGNATURE-----

--BOKacYhQ+x31HxR3--