[ruby-core:33858] Re: [Ruby 1.9-Feature#4183][Open] [ext/openssl] Timestamp support

On Wed, Dec 22, 2010 at 03:19:12AM +0900, Martin Bosslet wrote:
> Feature #4183: [ext/openssl] Timestamp support
> http://redmine.ruby-lang.org/issues/show/4183
> 
> Author: Martin Bosslet
> Status: Open, Priority: Normal
> Category: ext, Target version: 1.9.2
> 
> Hi,
> 
> I'd like to propose the attached code to support timestamp creation and verification in ext/openssl under a new module OpenSSL::Timestamp. It comes also with various tests and rDoc documentation. Since OpenSSL only supports timestamps beginning with OpenSSL 1.0, the entire code is in #if brackets and the module is defined only for OpenSSL versions >= 1.0. 

I think this is good functionality to add.

The patch seems good.  I noticed some code that is not necessary though.
You can remove these lines:

    /*
     * Creates a Factory.
     *
     * call-seq:
     *       OpenSSL::Timestamp::Factory.new    -> Factory
     */
    static VALUE
    ossl_tsfac_initialize(VALUE self)
    {
        return self;
    }

    rb_define_method(cTimestampFactory, "initialize", ossl_tsfac_initialize, 0);

and everything will Just Work™.

This patch is really long, so if nobody objects after a week or two,
I'll apply.

-- 
Aaron Patterson
http://tenderlovemaking.com/