ruby-core

Made some changes to the XMLRPC::ModRubyServer class that allows it to be loaded as a RubyHandler by ModRuby and prevent it from being reloaded every time a request is made. This can greatly improve performance when the server takes a while to load, such as when it is establishing database connections or loading lots of libraries.

1 message 2007/07/16

[#11724] ruby extension help — Oliver <python152@...>

hi, folks -

4 messages 2007/07/17

[#11726] Re: ruby extension help — Nobuyoshi Nakada <nobu@...> 2007/07/17

Hi,

[#11729] Re: ruby extension help — Oliver <python152@...> 2007/07/17

thanks for reply.

[#11732] Re: ruby extension help — Ryan Davis <ryand-ruby@...> 2007/07/17

[#11739] Re: Proposal: runtime-modifying Kernel methods should be keywords — Brent Roman <brent@...>

Just a follow up to on the idea of disallowing the

5 messages 2007/07/17

[#11740] Re: Proposal: runtime-modifying Kernel methods should be keywords — Charles Oliver Nutter <charles.nutter@...> 2007/07/17

Brent Roman wrote:

[#11742] Re: Proposal: runtime-modifying Kernel methods should be keywords — Calamitas <calamitates@...> 2007/07/17

On 17/07/07, Charles Oliver Nutter <charles.nutter@sun.com> wrote:

[#11743] Re: Proposal: runtime-modifying Kernel methods should be keywords — "John Lam (CLR)" <jflam@...> 2007/07/17

> Can you explain this? The way I see this, the piece of code that does

[#11747] Re: Proposal: runtime-modifying Kernel methods should be keywords — Calamitas <calamitates@...> 2007/07/18

On 18/07/07, John Lam (CLR) <jflam@microsoft.com> wrote:

[#11754] indentation / emacs woes — Ryan Davis <ryand-ruby@...>

OK. Can someone give me the tweaks I need to make ruby source read

10 messages 2007/07/18

[#11755] Re: indentation / emacs woes — Charles Oliver Nutter <charles.nutter@...> 2007/07/18

Ryan Davis wrote:

[#11757] Re: indentation / emacs woes — Charles Thornton <ceo@...> 2007/07/18

Charles Oliver Nutter wrote:

[#11759] Re: indentation / emacs woes — Ryan Davis <ryand-ruby@...> 2007/07/18

[#11762] Re: indentation / emacs woes — Charles Thornton <ceo@...> 2007/07/19

Ryan Davis wrote:

[#11766] Re: indentation / emacs woes — Steven Lumos <steven@...> 2007/07/19

Charles Thornton <ceo@hawthorne-press.com> writes:

[#11767] Re: indentation / emacs woes — David Flanagan <david@...> 2007/07/19

M-x set-variable

[#11769] Re: indentation / emacs woes — Charles Thornton <ceo@...> 2007/07/19

Steven Lumos wrote:

[#11770] Re: indentation / emacs woes — Nobuyoshi Nakada <nobu@...> 2007/07/20

Hi,

[#11833] Re: indentation / emacs woes — Steven Lumos <steven@...> 2007/07/30

Charles Thornton <ceo@hawthorne-press.com> writes:

[#11756] threads and heavy io on osx and linux — "ara.t.howard" <Ara.T.Howard@...>

15 messages 2007/07/18

[#11760] Re: [BUG] threads and heavy io on osx and linux — ville.mattila@... 2007/07/19

[#11761] Re: [BUG] threads and heavy io on osx and linux — "Vincent Isambart" <vincent.isambart@...> 2007/07/19

> i've tested on several platforms (*nixes) all all will hang if run a few

[#11758] Re: [BUG] threads and heavy io on osx and linux — Joel VanderWerf <vjoel@...> 2007/07/18

ara.t.howard wrote:

[#11763] Re: [BUG] threads and heavy io on osx and linux — brabuhr@... 2007/07/19

On 7/18/07, ara.t.howard <Ara.T.Howard@noaa.gov> wrote:

[#11765] Re: [BUG] threads and heavy io on osx and linux — brabuhr@... 2007/07/19

On 7/19/07, brabuhr@gmail.com <brabuhr@gmail.com> wrote:

[#11764] Re: [BUG] threads and heavy io on osx and linux — "Ben Schumacher" <benschumacher@...> 2007/07/19

On 7/18/07, ara.t.howard <Ara.T.Howard@noaa.gov> wrote:

[#11768] Re: [BUG] threads and heavy io on osx and linux — Corey Jewett <ml@...> 2007/07/19

Hung on the 13th run.

[#11771] Re: [BUG] threads and heavy io on osx and linux — "ara.t.howard" <ara.t.howard@...> 2007/07/20

[#11772] Re: [BUG] threads and heavy io on osx and linux — Corey Jewett <ml@...> 2007/07/20

Success for me, same ruby/OS as before.

[#11773] Re: [BUG] threads and heavy io on osx and linux — brabuhr@... 2007/07/20

On 7/20/07, ara.t.howard <ara.t.howard@gmail.com> wrote:

[#11774] Re: [BUG] threads and heavy io on osx and linux — "ara.t.howard" <ara.t.howard@...> 2007/07/20

[#11775] Re: [BUG] threads and heavy io on osx and linux — brabuhr@... 2007/07/21

On 7/20/07, ara.t.howard <ara.t.howard@gmail.com> wrote:

[#11776] Re: [BUG] threads and heavy io on osx and linux — "ara.t.howard" <ara.t.howard@...> 2007/07/21

[#11789] Re: [BUG] threads and heavy io on osx and linux — "ara.t.howard" <ara.t.howard@...> 2007/07/23

[#11777] Bug? array.push(*array) segfault — Ron M <rm_rails@...>

Is this a good place to report bugs?

2 messages 2007/07/22

[#11778] Re: Bug? array.push(*array) segfault — Nobuyoshi Nakada <nobu@...> 2007/07/22

Hi,

[#11795] What libraries to be unbundled? — "NAKAMURA, Hiroshi" <nakahiro@...>

-----BEGIN PGP SIGNED MESSAGE-----

27 messages 2007/07/24

[#11796] Re: What libraries to be unbundled? — gga <ggarra@...> 2007/07/24

NAKAMURA, Hiroshi wrote:

[#11797] Re: What libraries to be unbundled? — David Flanagan <david@...> 2007/07/24

I don't think that json should be unbundled. It is the interchange

[#11798] Re: What libraries to be unbundled? — James Edward Gray II <james@...> 2007/07/24

On Jul 24, 2007, at 1:39 PM, David Flanagan wrote:

[#11799] Re: What libraries to be unbundled? — David Flanagan <david@...> 2007/07/24

James Edward Gray II wrote:

[#11800] Re: What libraries to be unbundled? — "Mike Moore" <blowmage@...> 2007/07/24

On 7/24/07, David Flanagan <david@davidflanagan.com> wrote:

[#11801] Re: What libraries to be unbundled? — "Timothy J. Wood" <tjw@...> 2007/07/24

[#11832] Re: What libraries to be unbundled? — Evan Phoenix <evan@...> 2007/07/30

There is also a middle ground that has not been mentioned that Chad

[#11836] Re: What libraries to be unbundled? — mathew <meta@...> 2007/07/31

On 7/30/07, Evan Phoenix <evan@fallingsnow.net> wrote:

[#11834] Re: What libraries to be unbundled? — "Jonas Pfenniger" <zimbatm@...> 2007/07/31

Personally, I like ruby with "all strings attached". I remember that when I

[#11835] Re: What libraries to be unbundled? — Tom Lea <ruby@...> 2007/07/31

This seems like a logical approach. Give the user what they expect,

[#11802] Re: What libraries to be unbundled? — Ryan Davis <ryand-ruby@...> 2007/07/24

[#11804] Re: What libraries to be unbundled? — David Flanagan <david@...> 2007/07/24

NaHi's original message included a small list of candidates for

[#11805] Re: What libraries to be unbundled? — James Edward Gray II <james@...> 2007/07/24

On Jul 24, 2007, at 4:39 PM, David Flanagan wrote:

[#11822] Re: What libraries to be unbundled? — Charles Oliver Nutter <charles.nutter@...> 2007/07/27

James Edward Gray II wrote:

[#11825] Re: What libraries to be unbundled? — Urabe Shyouhei <shyouhei@...> 2007/07/28

NAKAMURA, Hiroshi wrote:

[#11848] Re: What libraries to be unbundled? — sheepman <sheepman@...> 2007/08/05

Hi,

[#12324] Re: What libraries to be unbundled? — "NAKAMURA, Hiroshi" <nakahiro@...> 2007/10/01

-----BEGIN PGP SIGNED MESSAGE-----

[#12327] Re: What libraries to be unbundled? — James Edward Gray II <james@...> 2007/10/01

On Oct 1, 2007, at 1:07 AM, NAKAMURA, Hiroshi wrote:

[#12349] Re: What libraries to be unbundled? — "NAKAMURA, Hiroshi" <nakahiro@...> 2007/10/02

-----BEGIN PGP SIGNED MESSAGE-----

[#12364] Re: What libraries to be unbundled? — James Edward Gray II <james@...> 2007/10/02

On Oct 1, 2007, at 9:44 PM, NAKAMURA, Hiroshi wrote:

[#12535] Re: What libraries to be unbundled? — "NAKAMURA, Hiroshi" <nakahiro@...> 2007/10/08

-----BEGIN PGP SIGNED MESSAGE-----

[#12536] Re: What libraries to be unbundled? — James Edward Gray II <james@...> 2007/10/08

On Oct 7, 2007, at 10:25 PM, NAKAMURA, Hiroshi wrote:

[#12538] Re: What libraries to be unbundled? — Michael Neumann <mneumann@...> 2007/10/08

NAKAMURA, Hiroshi schrieb:

[#12541] Re: What libraries to be unbundled? — James Edward Gray II <james@...> 2007/10/08

On Oct 8, 2007, at 8:16 AM, Michael Neumann wrote:

[#12545] Re: What libraries to be unbundled? — Michael Neumann <mneumann@...> 2007/10/08

James Edward Gray II schrieb:

[#12350] Re: What libraries to be unbundled? — Yukihiro Matsumoto <matz@...> 2007/10/02

Hi,

[#11813] Status of installed.files — "Sean E. Russell" <ser@...>

It has been a while since I've added files to the REXML library, and I've l=

3 messages 2007/07/25

[#11814] Re: Status of installed.files — "Sean E. Russell" <ser@...> 2007/07/25

It was MANIFEST, not installed.files, and I see that it has been removed=20

[#11816] Re: Status of installed.files — Nobuyoshi Nakada <nobu@...> 2007/07/25

Hi,

[#11815] Re: Parsing bug with 'return not' (was, Syntax bug) — "Rick DeNatale" <rick.denatale@...>

On 7/22/07, Gregory Brown <gregory.t.brown@gmail.com> wrote:

1 message 2007/07/25

[#11821] Columnize, irb, and ruby-debug — "Rocky Bernstein" <rocky.bernstein@...>

I've been working on/with Kent SIbilev's ruby-debug. The current sources in

3 messages 2007/07/27

[#11823] Re: Columnize, irb, and ruby-debug — "Chris Carter" <cdcarter@...> 2007/07/27

On 7/26/07, Rocky Bernstein <rocky.bernstein@gmail.com> wrote:

[#11824] Re: Columnize, irb, and ruby-debug — "Rocky Bernstein" <rocky.bernstein@...> 2007/07/27

Yes, PrettyPrint/PP seems like a good place. I'll work up a small patch for

[#11826] Rdoc allowing arbitrary HTML — "Robert Dober" <robert.dober@...>

Hi all

7 messages 2007/07/29

[#11827] Re: Rdoc allowing arbitrary HTML — Ryan Davis <ryand-ruby@...> 2007/07/29

[#11828] Re: Rdoc allowing arbitrary HTML — Joel VanderWerf <vjoel@...> 2007/07/29

Ryan Davis wrote:

[#11829] Re: Rdoc allowing arbitrary HTML — "Robert Dober" <robert.dober@...> 2007/07/29

On 7/29/07, Joel VanderWerf <vjoel@path.berkeley.edu> wrote:

[#11830] Re: Rdoc allowing arbitrary HTML — Joel VanderWerf <vjoel@...> 2007/07/29

Robert Dober wrote:

[#11831] Re: Rdoc allowing arbitrary HTML — "Robert Dober" <robert.dober@...> 2007/07/29

On 7/29/07, Joel VanderWerf <vjoel@path.berkeley.edu> wrote:

[#11837] Re: Rdoc allowing arbitrary HTML — Ryan Davis <ryand-ruby@...> 2007/07/31

[PATCH] XMLRPC::ModRubyServer

From: Chris Wailes <cwailes2@...>

Date: 2007-07-16 22:49:16 UTC

List: ruby-core #11720

Made some changes to the XMLRPC::ModRubyServer class that allows it to be loaded as a RubyHandler by ModRuby and prevent it from being reloaded every time a request is made.  This can greatly improve performance when the server takes a while to load, such as when it is establishing database connections or loading lots of libraries.

As well, I modified the way that the `XMLRPC::Server.dispatch` method calls the  service_hook Proc object so that it also passes the name of the XML-RPC method that is called along with the Proc object associated with the name, and the arguments for the method.

Sincerely,
Chris Wailes

Attachments (1)

ruby-changes.patch (4.16 KB, text/x-diff)

Index: lib/xmlrpc/server.rb
===================================================================
--- lib/xmlrpc/server.rb	(revision 12809)
+++ lib/xmlrpc/server.rb	(working copy)
@@ -129,9 +129,9 @@
     The service-hook is called with a (({Proc})) object and with the parameters for this (({Proc})).
     An example:
 
-       server.set_service_hook {|obj, *args|
+       server.set_service_hook {|method_name, method_obj, *args|
          begin
-           ret = obj.call(*args)  # call the original service-method
+           ret = method_obj.call(*args)  # call the original service-method
            # could convert the return value 
          resuce
            # rescue exceptions
@@ -333,7 +333,7 @@
         if @service_hook.nil?
           return obj.call(*args) 
         else
-          return @service_hook.call(obj, *args)
+          return @service_hook.call(methodname, obj, *args)
         end
       end
     end 
@@ -498,44 +498,91 @@
 
 =begin
 = XMLRPC::ModRubyServer
-== Description
-Implements a XML-RPC server, which works with Apache mod_ruby.
+== Synopsis
+ruby_file.rb:
+	def make_server
+		server = XMLRPC::ModRubyServer.new()
 
-Use it in the same way as CGIServer!
+		server.add_handler("michael.add") do |a,b|
+			a + b
+		end
 
+		server.add_handler("michael.div") do |a,b|
+			if b == 0
+				raise XMLRPC::FaultException.new(1, "division by zero")
+			else
+				a / b
+			end
+		end
+
+		server.set_default_handler do |name, *args|
+			raise XMLRPC::FaultException.new(-99, "Method #{name} missing" + " or wrong number of parameters!")
+		end
+
+		return server
+	end
+
+ruby.conf:
+#This is your mod_ruby configuration file.
+	LoadModule ruby_module modules/mod_ruby.so
+
+	DirectoryIndex index.rb
+
+	AddType text/html.rb
+	<IfModule mod_ruby.c>
+		RubyRequire apache/ruby-run
+
+		#If your file is at /path/to/your/ruby_file.rb
+		RubyAddPath /path/to/your
+		RubyRequire ruby_file
+
+		# Exec *.rb as ruby scripts.
+		<Files *.rb>
+			SetHandler ruby-object
+			RubyHandler Apache::RubyRun.instance
+			Options +ExecCGI
+		</Files>
+	</IfModule>
+
+	#This location doesn't actually corispond to any file so you can make it any path you want.
+	#This example makes the server address http://example.com/xmlrpcserver
+	<Location /xmlrpcserver>
+		SetHandler ruby-object
+		RubyHandler make_server
+
+		Order allow,deny
+		Allow from all
+	</Location>
+
+== Description
+Implements a XML-RPC server, which works with Apache mod_ruby.  By providing the 'handler' method a ModRubyServer object
+can be used as a RubyHandler by mod_ruby.  This prevents the server from being instantiated every time a request is made.
 == Superclass
 ((<XMLRPC::BasicServer>))
-=end 
+=end
 
 class ModRubyServer < BasicServer
+	def handler(apache_request)
+		@ap = apache_request
 
-  def initialize(*a)
-    @ap = Apache::request
-    super(*a)
-  end
+		header = Hash.new
+		@ap.headers_in.each {|key, value| header[key.capitalize] = value}
 
-  def serve
-    catch(:exit_serve) {
-      header = {}
-      @ap.headers_in.each {|key, value| header[key.capitalize] = value}
+		length = header['Content-length'].to_i
 
-      length = header['Content-length'].to_i
+		http_error(405, "Method Not Allowed") unless @ap.request_method  == "POST"
+		http_error(400, "Bad Request")        unless parse_content_type(header['Content-type']).first == "text/xml"
+		http_error(411, "Length Required")    unless length > 0
 
-      http_error(405, "Method Not Allowed") unless @ap.request_method  == "POST" 
-      http_error(400, "Bad Request")        unless parse_content_type(header['Content-type']).first == "text/xml"
-      http_error(411, "Length Required")    unless length > 0 
+		@ap.binmode
+		data = apache_request.read(length)
 
-      # TODO: do we need a call to binmode?
-      @ap.binmode
-      data = @ap.read(length)
+		http_error(400, "Bad Requiest") if data.nil? or data.size != length
 
-      http_error(400, "Bad Request")        if data.nil? or data.size != length
+		http_write(process(data), 200, "Content-type" => "text/xml; charset=utf-8")
 
-      http_write(process(data), 200, "Content-type" => "text/xml; charset=utf-8")
-    }
-  end
-
-
+		return Apache::OK
+	end
   private
 
   def http_error(status, message)

Thread

Prev Next

In This Thread

Prev Next