From: Marc-Andre Lafortune <redmine@...>
Date: 2009-10-24T15:34:00+09:00
Subject: [ruby-core:26268] [Bug #2261] lib/matrix: following the extensive changes

Bug #2261: lib/matrix: following the extensive changes
http://redmine.ruby-lang.org/issues/show/2261

Author: Marc-Andre Lafortune
Status: Open, Priority: Normal
Assigned to: Keiju Ishitsuka, Category: lib, Target version: 1.9.2
ruby -v: ruby 1.9.2dev (2009-10-24 trunk 25452) [x86_64-darwin10.0.0]

(a) Shouldn't r25412 (and other related commits) be also applied to the 1.8 branch?

(b) r25412 introduced Matrix#inspect_org. It is not documented.

Its output relies on the way the matrix information is stored internally by the Matrix class. Shouldn't this be considered implementation details and thus subject to change and not for public consumption?

It should either:
- be removed,
- be made private (although it is not used by the implementation) or
- be documented

I recommend the first option

(c) #compare_by_row_vectors and #compare_by should either:
- be removed (they are not used by the implementation anymore),
- be made private or
- be documented.

I recommend the first option


----------------------------------------
http://redmine.ruby-lang.org