From: Tony Arcieri <tony@...>
Date: 2009-10-07T14:13:45+09:00
Subject: [ruby-core:25984] Re: Disabling tainting

--0016e6470bdc1eb1df0475516933
Content-Type: text/plain; charset=ISO-8859-1

No, but it looks with that I could actually get some.  Thanks.

On Tue, Oct 6, 2009 at 10:08 PM, Nobuyoshi Nakada <nobu@ruby-lang.org>wrote:

> Hi,
>
> At Wed, 7 Oct 2009 12:11:57 +0900,
> > That's fine, but 99.9% of Ruby programs out there don't use it and it
> > impacts performance, so isn't making it an on-by-default configurable
> option
> > a good idea?
>
> Do you have exact data?
>
>
> Index: configure.in
> ===================================================================
> --- configure.in        (revision 25254)
> +++ configure.in        (working copy)
> @@ -2131,4 +2131,11 @@ esac
>  AC_SUBST(INSTALLDOC)
>
> +AC_ARG_ENABLE(taintness-checking,
> +       AS_HELP_STRING([--disable-taintness-checking], [do not check
> taintness]),
> +       [taintness_checking=$enableval], [taintness_checking=yes])
> +if test $taintness_checking = no; then
> +    AC_DEFINE(RUBY_DISABLE_TAINTNESS)
> +fi
> +
>  if test "$rb_with_pthread" = "yes"; then
>     THREAD_MODEL=pthread
> Index: include/ruby/ruby.h
> ===================================================================
> --- include/ruby/ruby.h (revision 25254)
> +++ include/ruby/ruby.h (working copy)
> @@ -513,8 +513,14 @@ VALUE rb_int2big(SIGNED_VALUE);
>  VALUE rb_newobj(void);
>  #define NEWOBJ(obj,type) type *obj = (type*)rb_newobj()
> +#ifdef RUBY_DISABLE_TAINTNESS
> +#define TAINT_IF_UNSAFE(level, obj) \
> +    if (rb_safe_level() >= level) FL_SET(obj, FL_TAINT | FL_UNTRUSTED)
> +#else
> +#define TAINT_IF_UNSAFE(level, obj) (void)0
> +#endif
>  #define OBJSETUP(obj,c,t) do {\
>     RBASIC(obj)->flags = (t);\
>     RBASIC(obj)->klass = (c);\
> -    if (rb_safe_level() >= 3) FL_SET(obj, FL_TAINT | FL_UNTRUSTED);\
> +    TAINT_IF_UNSAFE(3, obj);\
>  } while (0)
>  #define CLONESETUP(clone,obj) do {\
> @@ -891,4 +897,11 @@ struct RBignum {
>  #define FL_REVERSE(x,f) do {if (FL_ABLE(x)) RBASIC(x)->flags ^= (f);}
> while (0)
>
> +#ifdef RUBY_DISABLE_TAINTNESS
> +#define OBJ_TAINTED(x) 0
> +#define OBJ_TAINT(x) do {(void)(x);} while (0)
> +#define OBJ_UNTRUSTED(x) 0
> +#define OBJ_UNTRUST(x) do {(void)(x);} while (0)
> +#define OBJ_INFECT(x,s) do {(void)(x);(void)(s);} while (0)
> +#else
>  #define OBJ_TAINTED(x) (!!FL_TEST((x), FL_TAINT))
>  #define OBJ_TAINT(x) FL_SET((x), FL_TAINT)
> @@ -896,4 +909,5 @@ struct RBignum {
>  #define OBJ_UNTRUST(x) FL_SET((x), FL_UNTRUSTED)
>  #define OBJ_INFECT(x,s) do {if (FL_ABLE(x) && FL_ABLE(s)) RBASIC(x)->flags
> |= RBASIC(s)->flags & (FL_TAINT | FL_UNTRUSTED);} while (0)
> +#endif
>
>  #define OBJ_FROZEN(x) (!!FL_TEST((x), FL_FREEZE))
>
>
> --
> Nobu Nakada
>
>


-- 
Tony Arcieri
Medioh/Nagravision

--0016e6470bdc1eb1df0475516933
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

No, but it looks with that I could actually get some.=A0 Thanks.<br><br><di=
v class=3D"gmail_quote">On Tue, Oct 6, 2009 at 10:08 PM, Nobuyoshi Nakada <=
span dir=3D"ltr">&lt;<a href=3D"mailto:nobu@ruby-lang.org">nobu@ruby-lang.o=
rg</a>&gt;</span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, =
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi,<br>
<br>
At Wed, 7 Oct 2009 12:11:57 +0900,<br>
<div class=3D"im">&gt; That&#39;s fine, but 99.9% of Ruby programs out ther=
e don&#39;t use it and it<br>
&gt; impacts performance, so isn&#39;t making it an on-by-default configura=
ble option<br>
&gt; a good idea?<br>
<br>
</div>Do you have exact data?<br>
<br>
<br>
Index: <a href=3D"http://configure.in" target=3D"_blank">configure.in</a><b=
r>
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<br>
--- <a href=3D"http://configure.in" target=3D"_blank">configure.in</a> =A0 =
=A0 =A0 =A0(revision 25254)<br>
+++ <a href=3D"http://configure.in" target=3D"_blank">configure.in</a> =A0 =
=A0 =A0 =A0(working copy)<br>
@@ -2131,4 +2131,11 @@ esac<br>
=A0AC_SUBST(INSTALLDOC)<br>
<br>
+AC_ARG_ENABLE(taintness-checking,<br>
+ =A0 =A0 =A0 AS_HELP_STRING([--disable-taintness-checking], [do not check =
taintness]),<br>
+ =A0 =A0 =A0 [taintness_checking=3D$enableval], [taintness_checking=3Dyes]=
)<br>
+if test $taintness_checking =3D no; then<br>
+ =A0 =A0AC_DEFINE(RUBY_DISABLE_TAINTNESS)<br>
+fi<br>
+<br>
=A0if test &quot;$rb_with_pthread&quot; =3D &quot;yes&quot;; then<br>
 =A0 =A0 THREAD_MODEL=3Dpthread<br>
Index: include/ruby/ruby.h<br>
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<br>
--- include/ruby/ruby.h (revision 25254)<br>
+++ include/ruby/ruby.h (working copy)<br>
@@ -513,8 +513,14 @@ VALUE rb_int2big(SIGNED_VALUE);<br>
=A0VALUE rb_newobj(void);<br>
=A0#define NEWOBJ(obj,type) type *obj =3D (type*)rb_newobj()<br>
+#ifdef RUBY_DISABLE_TAINTNESS<br>
+#define TAINT_IF_UNSAFE(level, obj) \<br>
+ =A0 =A0if (rb_safe_level() &gt;=3D level) FL_SET(obj, FL_TAINT | FL_UNTRU=
STED)<br>
+#else<br>
+#define TAINT_IF_UNSAFE(level, obj) (void)0<br>
+#endif<br>
=A0#define OBJSETUP(obj,c,t) do {\<br>
 =A0 =A0 RBASIC(obj)-&gt;flags =3D (t);\<br>
 =A0 =A0 RBASIC(obj)-&gt;klass =3D (c);\<br>
- =A0 =A0if (rb_safe_level() &gt;=3D 3) FL_SET(obj, FL_TAINT | FL_UNTRUSTED=
);\<br>
+ =A0 =A0TAINT_IF_UNSAFE(3, obj);\<br>
=A0} while (0)<br>
=A0#define CLONESETUP(clone,obj) do {\<br>
@@ -891,4 +897,11 @@ struct RBignum {<br>
=A0#define FL_REVERSE(x,f) do {if (FL_ABLE(x)) RBASIC(x)-&gt;flags ^=3D (f)=
;} while (0)<br>
<br>
+#ifdef RUBY_DISABLE_TAINTNESS<br>
+#define OBJ_TAINTED(x) 0<br>
+#define OBJ_TAINT(x) do {(void)(x);} while (0)<br>
+#define OBJ_UNTRUSTED(x) 0<br>
+#define OBJ_UNTRUST(x) do {(void)(x);} while (0)<br>
+#define OBJ_INFECT(x,s) do {(void)(x);(void)(s);} while (0)<br>
+#else<br>
=A0#define OBJ_TAINTED(x) (!!FL_TEST((x), FL_TAINT))<br>
=A0#define OBJ_TAINT(x) FL_SET((x), FL_TAINT)<br>
@@ -896,4 +909,5 @@ struct RBignum {<br>
=A0#define OBJ_UNTRUST(x) FL_SET((x), FL_UNTRUSTED)<br>
=A0#define OBJ_INFECT(x,s) do {if (FL_ABLE(x) &amp;&amp; FL_ABLE(s)) RBASIC=
(x)-&gt;flags |=3D RBASIC(s)-&gt;flags &amp; (FL_TAINT | FL_UNTRUSTED);} wh=
ile (0)<br>
+#endif<br>
<br>
=A0#define OBJ_FROZEN(x) (!!FL_TEST((x), FL_FREEZE))<br>
<font color=3D"#888888"><br>
<br>
--<br>
Nobu Nakada<br>
<br>
</font></blockquote></div><br><br clear=3D"all"><br>-- <br>Tony Arcieri<br>=
Medioh/Nagravision<br>

--0016e6470bdc1eb1df0475516933--