[ruby-core:26237] [Bug #2256] net\ftp.rb failing on implicit cast of Pathname to string

Bug #2256: net\ftp.rb failing on implicit cast of Pathname to string
http://redmine.ruby-lang.org/issues/show/2256

Author: Sai Fujinaro
Status: Open, Priority: Normal
ruby -v: 1.9.1-p129-i386-mswin32

Trying to run gem install p4ruby gives an error:
can't convert Pathname into String

Running trace on rake shows that this is coming (among other places) from ftp.rb:679 and ftp.rb:547.  They are still trying to implicitly cast Pathname to string, but to_str was removed from Pathname in 1.9.1.  They can be fixed by just adding .to_s to those two lines:

ftp.rb:547:
-	retrbinary("RETR " + remotefile, blocksize, rest_offset) do |data|
+	retrbinary("RETR " + remotefile.to_s, blocksize, rest_offset) do |data|

ftp.rb: 676
    def list(*args, &block) # :yield: line
      cmd = "LIST"
      args.each do |arg|
-	cmd = cmd + " " + arg
+	cmd = cmd + " " + arg.to_s
      end
      if block

(Note that gem install p4ruby fails for other reasons than this, though)


----------------------------------------
http://redmine.ruby-lang.org