[ruby-core:26227] Re: [Bug #2247] Fixing compiler warnings

At Thu, 22 Oct 2009 00:59:42 +0900,
Mikhail T. <[e-mail]> wrote in [ruby-core:26217]:
> The attached patch fixes warnings, that I observed compiling
> with ``-Wall -Werror'' on RHEL-5.4/x86_64 system. Please,
> consider merging these changes in.

Thank you.

> The addressed problems are:
> 
>  * rb_thread_join was not declared (intern.h) with the rest of the rb_thread functions. Private declarations
>    existed in some C-files...

Applied in r25431.

>  * The PUSH_FRAME duly defined the local variable _frame as volatile. However, when the value of _frame was
>    assigned to the global ruby_frame, this qualifier was lost. There were as many warnings about this, as
>    there are invocations of the PUSH_FRAME macro.

Fixed in r17831.

>  * The little thread_timer() function MUST be declared as returning void*, because it is passed to
>    pthread_create(). Compiler warned, that a non-void function lacked the return-statement. I added one...

Fixed in r23201.

>  * regex.c in its error reporting tried to print ptrdiff_t value as int. On 64-bit platforms ptrdiff_t is,
>    usually, long int, but that's an impossibly large value for a regular expression's length.
>    Explicit casting of the pointer-difference down to int should be fine.

Fixed in r20465

>  * parse.y defined an unused static function arg_prepend()

Applied in r25432.

> Also, when compiling with a recent gcc at optimization level
> -O2 (or higher), util.c throws a number of warnings about
> breaking strict-aliasing rules. There is no /easy/ fix for
> this, but the work-around is to simply compile that one file
> with -fno-strict-aliasing (or whatever flag is needed for
> this with non-gcc compilers). A /sample/ patch for this issue
> is attached separately.

Fixed in r23353.

-- 
Nobu Nakada