From: Federico Builes <federico.builes@...>
Date: 2008-03-24T12:27:54+09:00
Subject: Re: Bugs in REXML

------=_Part_7576_30461285.1206329284456
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On 3/23/08, Sam Ruby <rubys@intertwingly.net> wrote:
> Federico Builes wrote:
>  > * Fix for standalone's default value in XMLDecl -
>  > http://rubyforge.org/tracker/index.php?func=detail&aid=19032&group_id=426&atid=1698

I've closed my patch as rejected since the standalone value's not
mandatory. The patch made it appear on every single XMLDecl if nothing
was specified so I preferred to just remove it.

I still think that docs for Document#stand_alone? should be updated to
reflect that if no standalone value has been given, nil will be
returned (not the default value as the docs kindly say).

> Please don't take this as being ungrateful, but in order to prevent
>  future regressions, any chance that test cases for the issues that these
>  fixes address can be added?

I'm attaching the tests.
It should've been done in the last email but since I didn't see a
folder for rexml in tests/ I skipped that step, that was my bad.

This patch creates a simple test_rexml file covering the issues
pointed in the mail and is by no means exhaustive. Please take a look
and if you see something's missing please let me know.

-- 
Federico

------=_Part_7576_30461285.1206329284456
Content-Type: application/octet-stream; name=tests_for_rexml.patch
Content-Transfer-Encoding: base64
X-Attachment-Id: f_fe6h3n7s
Content-Disposition: attachment; filename=tests_for_rexml.patch

SW5kZXg6IHRlc3QvcmV4bWwvdGVzdF9yZXhtbC5yYgo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB0ZXN0L3JleG1s
L3Rlc3RfcmV4bWwucmIJKHJldmlzaW9uIDApCisrKyB0ZXN0L3JleG1sL3Rlc3RfcmV4bWwucmIJ
KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDUgQEAKK3JlcXVpcmUgJ3Rlc3QvdW5pdCcKKworcmVx
dWlyZSAncmV4bWwvZG9jdW1lbnQnCisKKworY2xhc3MgVGVzdFJFWE1MIDwgVGVzdDo6VW5pdDo6
VGVzdENhc2UKKyAgaW5jbHVkZSBSRVhNTAorICAKKyAgZGVmIHNldHVwCisgICAgQGRvYyA9IERv
Y3VtZW50Lm5ldygiPHJvb3QvPiIpCisgICAgQGRvY190eXBlID0gRG9jVHlwZS5uZXcoIkludGVy
ZXN0aW5nIikKKyAgICBAZSA9IEVsZW1lbnQubmV3KCJ0ZXN0IikKKyAgZW5kCisKKyAgZGVmIHRl
c3RfdW5pcXVlX3htbGRlY2wKKyAgICBAZG9jLmFkZCBYTUxEZWNsLm5ldygiMy4xNDE1OTIiKQor
ICAgIEBkb2MuYWRkIFhNTERlY2wubmV3KCIxLjAiKQorICAgIGFzc2VydF9lcXVhbCgiPD94bWwg
dmVyc2lvbj0nMS4wJz8+PHJvb3QvPiIsIEBkb2MudG9fcykKKyAgZW5kCisKKyAgZGVmIHRlc3Rf
ZG9jdHlwZV9hdF9iZWdpbm5pbmcKKyAgICBAZG9jLmFkZCBYTUxEZWNsLm5ldworICAgIEBkb2Mu
YWRkIEBkb2NfdHlwZQorICAgIGFzc2VydF9lcXVhbCgiPD94bWwgdmVyc2lvbj0nMS4wJz8+PCFE
T0NUWVBFIEludGVyZXN0aW5nPjxyb290Lz4iLCBAZG9jLnRvX3MpCisgIGVuZAorCisgIGRlZiB0
ZXN0X3VuaXF1ZV9kb2N0eXBlCisgICAgQGRvYy5hZGQgWE1MRGVjbC5uZXcKKyAgICBAZG9jLmFk
ZCBEb2NUeXBlLm5ldygiTm90IEludGVyZXN0aW5nIikKKyAgICBAZG9jLmFkZCBAZG9jX3R5cGUK
KyAgICBhc3NlcnRfZXF1YWwoIjw/eG1sIHZlcnNpb249JzEuMCc/PjwhRE9DVFlQRSBJbnRlcmVz
dGluZz48cm9vdC8+IiwgQGRvYy50b19zKQorICBlbmQKKworICBkZWYgdGVzdF9nZXRfYXR0cmli
dXRlCisgICAgaCA9IEF0dHJpYnV0ZXMubmV3KEBlKQorICAgIGEgPSBBdHRyaWJ1dGUubmV3KCJm
b28iLCAiYmFyIikKKyAgICBoLmFkZCBhCisgICAgYXNzZXJ0X2VxdWFsKGEsIGguZ2V0X2F0dHJp
YnV0ZShhKSkKKyAgZW5kCisKKyAgZGVmIHRlc3RfZGVsZXRlX2F0dHJpYnV0ZQorICAgIEBlLmFk
ZF9hdHRyaWJ1dGUoImJsYSIsICJiYXoiKQorICAgIGFzc2VydF9lcXVhbChAZS5kZWxldGVfYXR0
cmlidXRlKCJibGEiKSwgQGUpCisgIGVuZAorZW5kCg==
------=_Part_7576_30461285.1206329284456--