[#15707] Schedule for the 1.8.7 release — "Akinori MUSHA" <knu@...>

Hi, developers,

21 messages 2008/03/01

[#15740] Copy-on-write friendly garbage collector — Hongli Lai <hongli@...99.net>

Hi.

31 messages 2008/03/03
[#15742] Re: Copy-on-write friendly garbage collector — Yukihiro Matsumoto <matz@...> 2008/03/03

Hi,

[#15829] Re: Copy-on-write friendly garbage collector — Daniel DeLorme <dan-ml@...42.com> 2008/03/08

Yukihiro Matsumoto wrote:

[#15756] embedding Ruby 1.9.0 inside pthread — "Suraj Kurapati" <sunaku@...>

Hello,

18 messages 2008/03/03
[#15759] Re: embedding Ruby 1.9.0 inside pthread — Nobuyoshi Nakada <nobu@...> 2008/03/04

Hi,

[#15760] Re: embedding Ruby 1.9.0 inside pthread — Yukihiro Matsumoto <matz@...> 2008/03/04

Hi,

[#15762] Re: embedding Ruby 1.9.0 inside pthread — "Suraj N. Kurapati" <sunaku@...> 2008/03/04

Yukihiro Matsumoto wrote:

[#15783] Adding startup and shutdown to Test::Unit — Daniel Berger <Daniel.Berger@...>

Hi all,

15 messages 2008/03/04

[#15835] TimeoutError in core, timeouts for ConditionVariable#wait — MenTaLguY <mental@...>

I've been reworking JRuby's stdlib to improve performance and fix

10 messages 2008/03/09

[#15990] Recent changes in Range#step behavior — "Vladimir Sizikov" <vsizikov@...>

Hi,

35 messages 2008/03/23
[#15991] Re: Recent changes in Range#step behavior — Dave Thomas <dave@...> 2008/03/23

[#15993] Re: Recent changes in Range#step behavior — "Vladimir Sizikov" <vsizikov@...> 2008/03/23

Hi Dave,

[#15997] Re: Recent changes in Range#step behavior — Dave Thomas <dave@...> 2008/03/23

[#16024] Re: Recent changes in Range#step behavior — "Vladimir Sizikov" <vsizikov@...> 2008/03/26

Hi Dave,

[#16025] Re: Recent changes in Range#step behavior — Yukihiro Matsumoto <matz@...> 2008/03/26

Hi,

[#16026] Re: Recent changes in Range#step behavior — Dave Thomas <dave@...> 2008/03/26

[#16027] Re: Recent changes in Range#step behavior — Yukihiro Matsumoto <matz@...> 2008/03/26

Hi,

[#16029] Re: Recent changes in Range#step behavior — Dave Thomas <dave@...> 2008/03/26

[#16030] Re: Recent changes in Range#step behavior — Yukihiro Matsumoto <matz@...> 2008/03/26

Hi,

[#16031] Re: Recent changes in Range#step behavior — Dave Thomas <dave@...> 2008/03/26

[#16032] Re: Recent changes in Range#step behavior — "Vladimir Sizikov" <vsizikov@...> 2008/03/26

On Wed, Mar 26, 2008 at 7:01 PM, Dave Thomas <dave@pragprog.com> wrote:

[#16033] Re: Recent changes in Range#step behavior — Dave Thomas <dave@...> 2008/03/26

[#16041] Re: Recent changes in Range#step behavior — David Flanagan <david@...> 2008/03/26

Dave Thomas wrote:

Bugs in REXML

From: "Federico Builes" <federico.builes@...>
Date: 2008-03-21 22:35:47 UTC
List: ruby-core #15975
Hi,

I think the following behaviors of REXML can be considered as bugs but I
wanted a small confirmation before implementing some patches:

1) XML Documents accept more than 1 XMLDecl (which is not allowed by
http://www.w3.org/TR/xml/#NT-prolog)

irb(main):001:0> require 'rexml/document'
irb(main):002:0> d = REXML::Document.new("<foo />")
irb(main):004:0> d.add REXML::XMLDecl.new
irb(main):005:0> d.add REXML::XMLDecl.new
=> [<?xml ... ?>, <?xml ... ?>, <foo/>]
irb(main):006:0> d.write
<?xml version='1.0'?><?xml version='1.0'?><foo/>

This behavior can be seen with "Document#to_s" and "Document#children"
too. It goes back to:

ruby_1_9/lib/rexml/document.rb:70
  if child.kind_of? XMLDecl
        @children.unshift child
        child.parent = self
  elsif...

Since it's not verifying if a XMLDecl already exists for the document.

2) DocTypes are being added to the end of the document.

This bug has been reported in
http://www.germane-software.com/projects/rexml/ticket/120 for at least 4
months.
To add a bit more, I _think_ this condition will fail (kind_of without "?"
unless it's defined like that somewhere else) but it'll never be met:

ruby_1_9/lib/rexml/document.rb:80
  if @children[ insert_before_index ] # Not null = not end of list
    if @children[ insert_before_index ].kind_of DocType

Since insert_before_index will be the expected position + 1.

Again, as I said earlier, I'm not entirely sure if my reasonings are fine
but I know the errors are there in 1.8 and probably 1.9 (unless I'm
missing something).

Comments?

-- 
Federico

In This Thread

Prev Next