Re: Are Depreciated Methods "add_final" & "remove_final" supposed to ACTUALLY WORK?

ts wrote:
>>>>>> "C" == Charles Thornton <[e-mail]> writes:
>>>>>>             
>
> C>    add_final and remove_final  DO NOT WORK
>
>  no, no it work. It's just a little strange :-)
>
> vgs% ruby -e 'a = "A"; ObjectSpace.add_finalizer(proc { p 12 }); ObjectSpace.call_finalizer(a); p 24'
> -e:1: warning: ObjectSpace::add_finalizer is deprecated; use define_finalizer
> -e:1: warning: ObjectSpace::call_finalizer is deprecated; use define_finalizer
> 24
> 12
> vgs% 
>
> C>     If they are supposed to be non-functional a lot
> C> of their code is still in place.
>
>  add_finalizer was deprecated since 1.6.0 if I'm right.
>
> Guy Decoux
>
>
>
>
>   
I should have been more clear!

"add_finalizer()" does not set the " need_call_final"
variable  to '1' .  Which means during GC,  objects are
not checked for finalizers added via "add_finalizer()"
unless "define_finalizer()" is also called!

Correct me if I am wrong.  But if GC runs across a
UNMARKED Object with a Finalizer during GC,
the object can be deleted WITHOUT the finalizer
ever running! 

This seems like a BUG to me!

The Following Modification Fixes the problem:

static VALUE
add_final(os, block)
    VALUE os, block;
{
    rb_warn("ObjectSpace::add_finalizer is deprecated; use 
define_finalizer");
    if (!rb_respond_to(block, rb_intern("call"))) {
    rb_raise(rb_eArgError, "wrong type argument %s (should be callable)",
         rb_obj_classname(block));
    }
    rb_ary_push(finalizers, block);  
    need_call_final = 1;                      /* Add this line! */
    return block;
}

   Chuck T.