From: Charles Oliver Nutter <charles.nutter@...>
Date: 2008-04-19T10:40:05+09:00
Subject: Re: [PATCH] SPARC architecture optimizations

Prashant Srinivasan wrote:
> Charles Oliver Nutter wrote:
>> Prashant Srinivasan wrote:
>>> Hello Matz,
>>>
>>> Thank you for the response.
>>>
>>> Yes, it is indeed okay to remove that particular invocation to 
>>> FLUSH_REGISTER_WINDOWS, since it is redundant.  Another call to 
>>> FLUSH_REGISTER_WINDOWS is made in rb_thread_save_context as a part of 
>>> THREAD_SAVE_CONTEXT.
>>> ie., in rb_thread_save_context(), the following exists.
>>
>> So has this been included? I saw some perf numbers relating to this 
>> and the gains were pretty substantial.
> 
> Hey Charlie,
> The above mentioned change has not made it in . . . but another flush 
> call(the one in EXEC_TAG) has been removed.  It'll be really cool if 
> someone can commit this  change - the call to flush windows here is 
> unnecessary - and it's quite an expensive call to have redundant 
> invocations.

Maybe if you could quantify expensive with some before/after numbers?

- Charlie