From: Prashant Srinivasan <Prashant.Srinivasan@...>
Date: 2008-04-09T06:23:09+09:00
Subject: Re: [PATCH] SPARC architecture optimizations

Yukihiro Matsumoto wrote:
> Hi,
>
> In message "Re: [PATCH] SPARC architecture optimizations"
>     on Fri, 4 Apr 2008 09:06:39 +0900, Prashant Srinivasan <Prashant.Srinivasan@Sun.COM> writes:
>
> |Hello Ruby-core,
> |
> | Can I request incorporation of this patch into the ruby_1_8 branch? 
>
> I am happy to merge the patch, but is it really OK to remove
> FLUSH_REGISTER_WINDOWS from THREAD_SAVE_CONTEXT()?
>
>   

Hello Matz,

 Thank you for the response.

 Yes, it is indeed okay to remove that particular invocation to 
FLUSH_REGISTER_WINDOWS, since it is redundant.  Another call to 
FLUSH_REGISTER_WINDOWS is made in rb_thread_save_context as a part of 
THREAD_SAVE_CONTEXT. 

ie., in rb_thread_save_context(), the following exists.

[snipped code here]

static void
rb_thread_save_context(th)
    rb_thread_t th;
{

[snipped code here]
    FLUSH_REGISTER_WINDOWS;
    MEMCPY(th->stk_ptr, th->stk_pos, VALUE, th->stk_len);
[snipped code here]
 

Thanks,
 -ps


-- 
Prashant Srinivasan
F/OSS Enthusiast
Sun Microsystems, Inc.
http://blogs.sun.com/prashant
GnuPG key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x82FBDE5A