Re: uri test failures. (Re: [ruby-cvs] ruby/lib, ruby/lib/uri: Lovely RDOC patches from mathew (metaATpoboxDOTcom) on URI/* and getoptlong.rb)

Tanaka Akira wrote:

>In article <[e-mail]>,
>  [e-mail] (ryan) writes:
>  
>
>>ryan        Wed, 24 Aug 2005 14:08:01 +0900
>>
>>  Modified files:
>>    ruby/lib:
>>      .document getoptlong.rb
>>    ruby/lib/uri:
>>      ftp.rb generic.rb http.rb https.rb mailto.rb
>>  Log:
>>    Lovely RDOC patches from mathew (metaATpoboxDOTcom) on URI/* and getoptlong.rb
>>    
>>
>
>It causes following test failures.
>
>  2) Failure:
>test_parse(URI::TestFTP) [/home/akr/chkbuild/tmp/build/ruby-trunk/ruby/test/uri/test_ftp.rb:24]:
><["ftp", "user:pass", "host.com", 21, "/abc/def", nil]> expected but was
><["ftp", "user:pass", "host.com", 21, "abc/def", nil]>.
>
>  3) Failure:
>test_parse(URI::TestGeneric) [/home/akr/chkbuild/tmp/build/ruby-trunk/ruby/test/uri/test_generic.rb:44]:
><["ftp", nil, "ftp.is.co.za", 21, "/rfc/rfc1808.txt", nil]> expected but was
><["ftp", nil, "ftp.is.co.za", 21, "rfc/rfc1808.txt", nil]>.
>
>It seems that non-documentation code is modifified.
>  
>

The test code is incorrect. As documented in RFC 1738 section 3.2.2 (and 
now documented in the classes too), 
ftp://ftp.example.com/foo/bar/file.ext should parse into a server of 
ftp.example.com, and a path of foo/bar/file.ext with no leading slash.

If you want a leading slash on your chdir command, you need to escape it 
in the URL, e.g. ftp://ftp.example.com/%2Ffoo/bar/file.ext.

See also 
<URL:http://rubyforge.org/tracker/index.php?func=detail&aid=2055&group_id=426&atid=1698>

Unfortunately, I didn't notice the tests, so I didn't update them.


mathew