Re: Pathname#walk for traversing path nodes (patch)

In article <[e-mail]>,
  ES <[e-mail]> writes:

> Here is a small addition to Pathname against 1.9, probably suited
> for 1.8. Makes doing something for each node in a path easier.

> +  #  Pathname.new('/path/to/some/file.rb').walk {|dir| p dir}
> +  #     #<Pathname:/path>
> +  #     #<Pathname:/path/to>
> +  #     #<Pathname:/path/to/some>
> +  #     #<Pathname:/path/to/some/file.rb>

It seems that Pathname#walk doesn't yield the root directory.
Is it intended?  How useful/unuseful with this behavior?

Another question is about relative pathnames.

% ruby -rpathname -e 'Pathname.new("a/b/c").walk {|x| p x}'
#<Pathname:/b>
#<Pathname:/b/c>

The directory "a" doesn't appear in the result.
I think it is not intended.

Index: pathname.rb
===================================================================
RCS file: /src/ruby/lib/pathname.rb,v
retrieving revision 1.42
diff -u -p -r1.42 pathname.rb
--- pathname.rb	10 Jul 2005 15:17:18 -0000	1.42
+++ pathname.rb	23 Aug 2005 03:20:08 -0000
@@ -423,6 +423,33 @@ class Pathname
   end
 
   #
+  # Iterates over and yields a new Pathname object
+  # for each element in the given path.
+  #
+  #  Pathname.new('/path/to/some/file.rb').walk {|dir| p dir}
+  #     #<Pathname:/path>
+  #     #<Pathname:/path/to>
+  #     #<Pathname:/path/to/some>
+  #     #<Pathname:/path/to/some/file.rb>
+  #
+  def walk()
+    paths = []
+    v = self
+    if absolute?
+      until v.root?
+        paths << v
+        v = v.dirname
+      end
+    else
+      until v.to_s == '.'
+        paths << v
+        v = v.dirname
+      end
+    end
+    paths.reverse_each {|path| yield path }
+  end
+
+  #
   # Pathname#+ appends a pathname fragment to this one to produce a new Pathname
   # object.
   #
-- 
Tanaka Akira