Re: Exceptions in threads all get converted to a TypeError

Hi,

At Wed, 17 Aug 2005 04:20:52 +0900,
Paul van Tilburg wrote in [ruby-core:05552]:
> I am using ruby1.8 from Debian unstable, which seems to be Ruby 1.8.2
> with some patches from CVS (ruby -v already returns 1.8.3).  I am
> experiencing some problems with exceptions in Threads since a few
> days/weeks.  They all seem to be converted to a TypeError, which makes
> debugging very hard for the app I am working on.

I have a patch, which is to reduce exception objects, however
it seems to fix the bug too.


Index: eval.c
===================================================================
RCS file: /cvs/ruby/src/ruby/eval.c,v
retrieving revision 1.818
diff -U2 -p -r1.818 eval.c
--- eval.c	16 Aug 2005 15:24:14 -0000	1.818
+++ eval.c	16 Aug 2005 22:28:23 -0000
@@ -4353,14 +4353,13 @@ rb_mod_protected_method_defined(mod, mid
 }
 
-NORETURN(static VALUE terminate_process _((int, const char *, long)));
+NORETURN(static VALUE terminate_process _((int, VALUE)));
 static VALUE
-terminate_process(status, mesg, mlen)
+terminate_process(status, mesg)
     int status;
-    const char *mesg;
-    long mlen;
+    VALUE mesg;
 {
     VALUE args[2];
     args[0] = INT2NUM(status);
-    args[1] = rb_str_new(mesg, mlen);
+    args[1] = mesg;
 
     rb_exc_raise(rb_class_new_instance(2, args, rb_eSystemExit));
@@ -4372,5 +4371,5 @@ rb_exit(status)
 {
     if (prot_tag) {
-	terminate_process(status, "exit", 4);
+	terminate_process(status, rb_str_new("exit", 4));
     }
     ruby_finalize();
@@ -4477,7 +4476,7 @@ rb_f_abort(argc, argv)
 
 	rb_scan_args(argc, argv, "1", &mesg);
-	StringValue(argv[0]);
-	rb_io_puts(argc, argv, rb_stderr);
-	terminate_process(EXIT_FAILURE, RSTRING(argv[0])->ptr, RSTRING(argv[0])->len);
+	StringValue(mesg);
+	rb_io_puts(1, &mesg, rb_stderr);
+	terminate_process(EXIT_FAILURE, mesg);
     }
     return Qnil;		/* not reached */
@@ -10490,5 +10489,5 @@ rb_thread_switch(n)
 	ruby_errinfo = th_raise_exception;
 	ruby_current_node = th_raise_node;
-	terminate_process(sysexit_status(ruby_errinfo), 0, 0);
+	rb_exc_raise(th_raise_exception);
 	break;
       case RESTORE_NORMAL:


-- 
Nobu Nakada