From: jonathan gold <dev@...>
Date: 2006-07-11T01:14:23+09:00
Subject: Re: [PATCH] --fqname option to test/unit/autorunner.rb

Daniel --

Thanks very much for taking a look at it. What is the typical path for 
changes submitted in this way? In particular, I'm curious to know how I 
can track which release they'll start appearing in, so I can remove my 
local changes in favor of those inside the standard distro.

Thanks again for your help.

jon

Berger, Daniel wrote:
>>-----Original Message-----
>>From: jonathan gold [mailto:dev@samizdatdigital.org] 
>>Sent: Thursday, July 06, 2006 3:51 PM
>>To: ruby-core@ruby-lang.org
>>Subject: [PATCH] --fqname option to test/unit/autorunner.rb
>>
>>
>>Hello,
>>
>>I'd like to contribute a patch to test/unit/autorunner.rb 
>>that allows a 
>>new option '--fqname', which would be the logical AND of what 
>>is today 
>>'--testcase' with '--name'.
>>
>>I have tests in files with many testcases, some of which use 
>>subclassing 
>>or an include to repeatedly run different variations of the 
>>same test. 
>>Right now, if the method "test_foo" is defined/included in both 
>>FooTestCase and BarTestCase, there is no way for me to tell 
>>autorunner 
>>to run just the "test_foo" method in the FooTestCase class. If I say 
>>'--testcase FooTestCase', I run all methods in FooTestCase. If I say 
>>'--name test_foo' then I run test_foo in both FooTestCase and in 
>>BarTestCase. The proposed patch allows me to say '--fqname 
>>FooTestCase#test_foo' and have only that single test case be run.
> 
> 
> It's not a bad idea, though in practice I would say it's unusual to have
> more than one test class per file.
> 
> 
>>I'm new to the ruby community, so apologize if I'm overlooking the 
>>correcct way to submit code like this. I didn't see any 
>>guidelines for 
>>applying to become a committer or someone with the rights to request 
>>write access to the CVS repository, and, judging from the 
>>email threads 
>>on this list, the thing to do is put 'PATCH' in the subject line and 
>>then provide the diff (attached). Hopefully this is correct, 
>>but please 
>>let me know what I can do to help make things easier.
> 
> 
> Your subject and attachment is fine (you can also submit patches via the
> tracker on RubyForge), but I wouldn't expect CVS commit access anytime
> soon. :)
> 
> Regards,
> 
> Dan
> 
> 
> This communication is the property of Qwest and may contain confidential or
> privileged information. Unauthorized use of this communication is strictly 
> prohibited and may be unlawful.  If you have received this communication 
> in error, please immediately notify the sender by reply e-mail and destroy 
> all copies of the communication and any attachments.
>