Re: Multi-Line Date Formate Patch

On Aug 1, 2006, at 9:50 AM, [e-mail] wrote:

> Hi,
>
> At Tue, 1 Aug 2006 23:22:37 +0900,
> James Edward Gray II wrote in [ruby-core:08474]:
>>> Below is my one character patch to resolve this issue.
>>
>> Uh, hello?  Is there any good reason not to apply this patch?
>
> It seems insufficient.

Ah, I did miss the method in Date.  Good catch.  However, I doubt we  
need to patch the calls like:

   cc = c.sub(/\A%[EO]?(.)\Z/o, '%\\1')

Those are only used to simplify escapes located by the parser and  
none of the escape sequences should contain newlines.

I think that means we only need to patch the two lines, instead of  
all four.  Am I making sense?

James Edward Gray II

Index: lib/date/format.rb
===================================================================
RCS file: /src/ruby/lib/date/format.rb,v
retrieving revision 1.12
diff -u -r1.12 format.rb
--- lib/date/format.rb	6 Feb 2005 05:05:18 -0000	1.12
+++ lib/date/format.rb	1 Aug 2006 15:11:47 -0000
@@ -51,7 +51,7 @@
    }
    def self.__strptime(str, fmt, elem)
-    fmt.scan(/%[EO]?.|./o) do |c|
+    fmt.scan(/%[EO]?.|./mo) do |c|
        cc = c.sub(/\A%[EO]?(.)\Z/o, '%\\1')
        case cc
        when /\A\s/o
@@ -490,7 +490,7 @@
    def strftime(fmt='%F')
      o = ''
-    fmt.scan(/%[EO]?.|./o) do |c|
+    fmt.scan(/%[EO]?.|./mo) do |c|
        cc = c.sub(/^%[EO]?(.)$/o, '%\\1')
        case cc
        when '%A'; o << DAYNAMES[wday]