From: Zachary Scott <e@...>
Date: 2015-03-28T01:36:28-07:00
Subject: [ruby-core:68667] Re: [Ruby trunk - Bug #10967] [Open] Is "warning: private attribute?" wrong?

--047d7bd76f7c30bbee0512552573
Content-Type: text/plain; charset=UTF-8

I'd like to know the intention behind this warning.. but so far haven't
seen it.

Also, since this behavior was added in a minor release, we can't really
change it now until the next major.. IF we care about semver for this,
which may not be the case

On Thursday, March 12, 2015, <santiago@wyeworks.com> wrote:

> Issue #10967 has been updated by Santiago Pastorino.
>
>
> One possible fix (the one removing the warning) ...
> https://github.com/ruby/ruby/pull/849
>
> ----------------------------------------
> Bug #10967: Is "warning: private attribute?" wrong?
> https://bugs.ruby-lang.org/issues/10967#change-51839
>
> * Author: Santiago Pastorino
> * Status: Open
> * Priority: Normal
> * Assignee:
> * ruby -v: ruby 2.3.0dev (2015-03-01 trunk 49796) [x86_64-darwin14]
> * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
> ----------------------------------------
> The following code ...
>
> ```
> class Y
>   def initialize
>     @x = "ZOMG"
>   end
>
>   def print_x
>     puts x
>   end
>
>   private
>
>   attr_reader :x
> end
>
> Y.new.print_x
> ```
>
> outputs ...
>
> ```
> test.rb:12: warning: private attribute?
> ```
>
> I tend to think this warning is wrong, I was surprised by
> https://github.com/rack/rack/pull/811 and I think this is a completely
> valid use case.
>
> Also this code ...
>
> ```
> class Y
>   def initialize
>     @x = "ZOMG"
>   end
>
>   def print_x
>     puts x
>   end
>
>   def assign_x
>     self.x = "ZOMG ZOMG"
>   end
>
>   private
>
>   attr_accessor :x
> end
>
> y = Y.new
> y.assign_x
> y.print_x
> ```
>
> Works fine with warnings also. So a private writer works ok when the
> receiver is `self` because Ruby has a special case for it, this make me
> think that private writers were thought to be used.
>
> So ... am I wrong thinking that the warning should be removed or the self
> special case shouldn't work and be removed from Ruby code?. It doesn't make
> sense to me to have both things.
>
>
>
> --
> https://bugs.ruby-lang.org/
>

--047d7bd76f7c30bbee0512552573
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I&#39;d like to know the intention behind this warning.. but so far=C2=A0ha=
ven&#39;t seen it.<div><br></div><div>Also, since this behavior was added i=
n a minor release, we can&#39;t really change it now until the next major..=
 IF we care about semver for this, which may not be the case<span></span></=
div><div><br>On Thursday, March 12, 2015,  &lt;<a href=3D"mailto:santiago@w=
yeworks.com">santiago@wyeworks.com</a>&gt; wrote:<br><blockquote class=3D"g=
mail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-l=
eft:1ex">Issue #10967 has been updated by Santiago Pastorino.<br>
<br>
<br>
One possible fix (the one removing the warning) ... <a href=3D"https://gith=
ub.com/ruby/ruby/pull/849" target=3D"_blank">https://github.com/ruby/ruby/p=
ull/849</a><br>
<br>
----------------------------------------<br>
Bug #10967: Is &quot;warning: private attribute?&quot; wrong?<br>
<a href=3D"https://bugs.ruby-lang.org/issues/10967#change-51839" target=3D"=
_blank">https://bugs.ruby-lang.org/issues/10967#change-51839</a><br>
<br>
* Author: Santiago Pastorino<br>
* Status: Open<br>
* Priority: Normal<br>
* Assignee:<br>
* ruby -v: ruby 2.3.0dev (2015-03-01 trunk 49796) [x86_64-darwin14]<br>
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN<br>
----------------------------------------<br>
The following code ...<br>
<br>
```<br>
class Y<br>
=C2=A0 def initialize<br>
=C2=A0 =C2=A0 @x =3D &quot;ZOMG&quot;<br>
=C2=A0 end<br>
<br>
=C2=A0 def print_x<br>
=C2=A0 =C2=A0 puts x<br>
=C2=A0 end<br>
<br>
=C2=A0 private<br>
<br>
=C2=A0 attr_reader :x<br>
end<br>
<br>
Y.new.print_x<br>
```<br>
<br>
outputs ...<br>
<br>
```<br>
test.rb:12: warning: private attribute?<br>
```<br>
<br>
I tend to think this warning is wrong, I was surprised by <a href=3D"https:=
//github.com/rack/rack/pull/811" target=3D"_blank">https://github.com/rack/=
rack/pull/811</a> and I think this is a completely valid use case.<br>
<br>
Also this code ...<br>
<br>
```<br>
class Y<br>
=C2=A0 def initialize<br>
=C2=A0 =C2=A0 @x =3D &quot;ZOMG&quot;<br>
=C2=A0 end<br>
<br>
=C2=A0 def print_x<br>
=C2=A0 =C2=A0 puts x<br>
=C2=A0 end<br>
<br>
=C2=A0 def assign_x<br>
=C2=A0 =C2=A0 self.x =3D &quot;ZOMG ZOMG&quot;<br>
=C2=A0 end<br>
<br>
=C2=A0 private<br>
<br>
=C2=A0 attr_accessor :x<br>
end<br>
<br>
y =3D Y.new<br>
y.assign_x<br>
y.print_x<br>
```<br>
<br>
Works fine with warnings also. So a private writer works ok when the receiv=
er is `self` because Ruby has a special case for it, this make me think tha=
t private writers were thought to be used.<br>
<br>
So ... am I wrong thinking that the warning should be removed or the self s=
pecial case shouldn&#39;t work and be removed from Ruby code?. It doesn&#39=
;t make sense to me to have both things.<br>
<br>
<br>
<br>
--<br>
<a href=3D"https://bugs.ruby-lang.org/" target=3D"_blank">https://bugs.ruby=
-lang.org/</a><br>
</blockquote></div>

--047d7bd76f7c30bbee0512552573--