[#68478] Looking for MRI projects for Ruby Google Summer of Code 2015 — Tony Arcieri <bascule@...>

Hi ruby-core,

10 messages 2015/03/10

[ruby-core:68546] [Ruby trunk - Bug #10825] Fix build error in sdbm under Windows

From: nagachika00@...
Date: 2015-03-17 16:59:32 UTC
List: ruby-core #68546
Issue #10825 has been updated by Tomoyuki Chikanaga.

Backport changed from 2.0.0: DONE, 2.1: REQUIRED, 2.2: DONE to 2.0.0: DONE, 2.1: DONE, 2.2: DONE

Backported into `ruby_2_1` branch at r49994.

----------------------------------------
Bug #10825: Fix build error in sdbm under Windows
https://bugs.ruby-lang.org/issues/10825#change-51865

* Author: Owen Rodley
* Status: Closed
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-02-03) [i386-mingw32]
* Backport: 2.0.0: DONE, 2.1: DONE, 2.2: DONE
----------------------------------------
Hi,

The attached patch fixes an error I was getting while attempting to compile
revision 49476 of Ruby under Windows (mingw), specifically in ext/sdbm/_sdbm.c.
One of the printf macros defined in "ruby/ruby.h" (PRIdPTRDIFF) is being
used, but the header does not get included, so the macro is undefined.

I believe the issue was introduced in revision 49021, with the addition of
this macro to the file. I guess there is some difference in configuration
between Windows and other platforms that causes the header to get included
appropriately under other platforms, but not under Windows.

I just included "ruby/ruby.h" in _sdbm.c explicitly to fix the issue, but
since I don't know how it is working under other platforms I'm not sure if
this is the best way to fix it. Please let me know.

---Files--------------------------------
restore-windows-build.patch (182 Bytes)


-- 
https://bugs.ruby-lang.org/

In This Thread

Prev Next