From: Nobuyoshi Nakada <nobu@...>
Date: 2015-03-12T21:53:23+09:00
Subject: [ruby-core:68507] Re: [Ruby trunk - Feature #10532] [PATCH] accept_nonblock supports "exception: false"

On 2015/03/12 17:38, Nobuyoshi Nakada wrote:
> On 2015/03/12 12:08, Eric Wong wrote:
>> I think the st_delete call in rb_get_kwargs interacts badly with with
>> keyword optimizations ko1 did in 2.2.  My work-in-progress patch
>> gets stuck on the OpenSSL read_nonblock (from
>> ext/openssl/lib/openssl/buffering.rb) in test/openssl/test_ssl.rb
> 
> It is an intentional behavior.
> 
> Add this after `rb_get_kwargs()` call.
> 
>     if (except != Qundef)
> 	rb_hash_aset(opts, ID2SYM(id_exception), except);

Or you can just `rb_hash_lookup2(opts, ID2SYM(id_exception), Qundef)`,
if you want to pass the whole options without checking.

-- 
Nobu Nakada