ruby-core

Hello,

if I get this correct, the methods in FileUtils are supposed to mirror
the unix shell commands.

In shell mkdir can be used in this way:

(flori@lambda:flori 0)$ mkdir -m 2750 foo
(flori@lambda:flori 0)$ ls -ld foo
drwxr-s---  2 flori flori 4096 Dec  3  2004 foo

But if I do
  >> FileUtils::mkdir 'foo', :mode => 02750

the s-bit is silently ignored, because the mkdir libc function and thus
Dir::mkdir ignores some bits depending  on
the used operation system.

I've made a patch (attached) to chmod the file in FileUtils::mkdir(_p)
to the given mode, and also changed the Dir::mkdir comment to warn
people about the libc behaviour.

Perhaps Dir::mkdir should be portable in Ruby and not rely on the
operating system's behaviour? Or is it more important to make the
original libc mkdir available in Dir class?

-- 
Florian Frank

Attachments (1)

mkdir.patch (2.66 KB, text/x-diff)

Index: dir.c
===================================================================
RCS file: /src/ruby/dir.c,v
retrieving revision 1.134
diff -u -p -r1.134 dir.c
--- dir.c	22 Nov 2004 15:26:02 -0000	1.134
+++ dir.c	3 Dec 2004 12:36:08 -0000
@@ -870,8 +870,9 @@ dir_s_chroot(dir, path)
  *     Dir.mkdir( string [, integer] ) => 0
  *
  *  Makes a new directory named by <i>string</i>, with permissions
- *  specified by the optional parameter <i>anInteger</i>. The
- *  permissions may be modified by the value of
+ *  specified by the optional parameter <i>anInteger</i>; the
+ *  bits are interpreted exactly as the operating system's mkdir libc ibrary
+ *  call does. The permissions may be modified by the value of
  *  <code>File::umask</code>, and are ignored on NT. Raises a
  *  <code>SystemCallError</code> if the directory cannot be created. See
  *  also the discussion of permissions in the class documentation for
Index: lib/fileutils.rb
===================================================================
RCS file: /src/ruby/lib/fileutils.rb,v
retrieving revision 1.46
diff -u -p -r1.46 fileutils.rb
--- lib/fileutils.rb	8 Oct 2004 12:37:19 -0000	1.46
+++ lib/fileutils.rb	3 Dec 2004 12:36:13 -0000
@@ -131,6 +131,15 @@ module FileUtils
     true
   end
 
+  def create_dir(path, mode)
+    if mode
+      Dir.mkdir path.sub(%r</\z>, ''), mode
+      File.chmod mode, path
+    else
+      Dir.mkdir path.sub(%r</\z>, ''), 0777 & ~File.umask
+    end
+  end
+  private :create_dir
 
   #
   # Options: mode noop verbose
@@ -147,10 +156,8 @@ module FileUtils
     list = fu_list(list)
     fu_output_message "mkdir #{options[:mode] ? ('-m %03o ' % options[:mode]) : ''}#{list.join ' '}" if options[:verbose]
     return if options[:noop]
-
-    mode = options[:mode] || (0777 & ~File.umask)
     list.each do |dir|
-      Dir.mkdir dir.sub(%r</\z>, ''), mode
+      create_dir dir, options[:mode]
     end
   end
 
@@ -176,11 +183,10 @@ module FileUtils
     fu_output_message "mkdir -p #{options[:mode] ? ('-m %03o ' % options[:mode]) : ''}#{list.join ' '}" if options[:verbose]
     return *list if options[:noop]
 
-    mode = options[:mode] || (0777 & ~File.umask)
     list.map {|path| path.sub(%r</\z>, '') }.each do |path|
       # optimize for the most common case
       begin
-        Dir.mkdir path, mode
+        create_dir path, options[:mode]
         next
       rescue SystemCallError
         next if File.directory?(path)
@@ -193,7 +199,7 @@ module FileUtils
       end
       stack.reverse_each do |path|
         begin
-          Dir.mkdir path, mode
+          create_dir path, options[:mode]
         rescue SystemCallError => err
           raise unless File.directory?(path)
         end

Thread

Prev Next

In This Thread

Prev Next