Re: [PATCH] Marshal.dump'ing OpenStruct objects

Hi,

At Thu, 2 Dec 2004 09:38:31 +0900,
Yukihiro Matsumoto wrote in [ruby-core:03863]:
> |I think this allows one to dump OpenStruct objects, and addresses the
> |data compatibility issue:
> 
> I have recently restored the old behavior, but this one seems
> superior.  I will take this.

This change makes no sense as for the compatibility.

  $ cvs up -A lib/ostruct.rb
  U lib/ostruct.rb
  $ ./ruby -rostruct -e 'o=OpenStruct.new;o.foo=1;print Marshal.dump(o)' > ostruct.dump
  $ od -tx1z ostruct.dump
  0000000 04 08 65 3a 1a 4f 70 65 6e 53 74 72 75 63 74 3a  >..e:.OpenStruct:<
  0000020 3a 4d 61 72 73 68 61 6c 65 72 55 3a 0f 4f 70 65  >:MarshalerU:.Ope<
  0000040 6e 53 74 72 75 63 74 6f 3b 06 06 3a 0b 40 74 61  >nStructo;..:.@ta<
  0000060 62 6c 65 7b 06 3a 08 66 6f 6f 69 06              >ble{.:.fooi.<
  0000074
  $ cvs up -r1.11 lib/ostruct.rb
  U lib/ostruct.rb
  $ ./ruby -rostruct -e 'p Marshal.load(STDIN)' < ostruct.dump
  -e:1:in `load': undefined class/module OpenStruct::Marshaler (ArgumentError)
          from -e:1

It is same as simply adding marshal_dump/marhsal_load.

-- 
Nobu Nakada