[ruby-core:23868] Re: [Bug #1633] ARGF#close and ARGF#skip are Often Fatal on 1.9

Hi,

In message "Re: [ruby-core:23853] [Bug #1633] ARGF#close and ARGF#skip are Often Fatal on 1.9"
    on Mon, 15 Jun 2009 06:07:37 +0900, Run Paint Run Run <[e-mail]> writes:

|I don't claim to fully understand this issue, but I'd like to explain some differences between ARGF#close/#skip on 1.8 and 1.9 which seem peculiar.

Both 1.9 and 1.8 have bugs:

  * 1.8 ARGF.close does not call #close on T_FILE objects.  It calls
    rb_io_close() directly, which does not check duplicated close.

  * 1.9 IO#close does not close file descriptors 0, 1, 2.  It should
    close them when close is called explicitly.

  * ARGF.skip for both versions should not close if current_file is
    not initialized.

As a result:

  * "ARGF.close; ARGF.closed?" should be true on 1.9.

  * "ARGF.close; ARGF.close" should raise an exception on 1.8.

  * "ARGF.skip" should not raise any exception on both versions.

  * "ARGF.read; ARGF.skip" should not raise any exceptions.

I will check in the fix.

							matz.