[ruby-core:23765] Re: [Bug #977] caller for all threads patch

I'm not sure I understand. The part I was responding to is the code in the
patch underlined with !!! listed below.

> +VALUE rb_thread_backtrace(VALUE thval, int lev);
> +
> +static VALUE
> +rb_thread_caller_m(int argc, VALUE *argv, VALUE thval)
> +{
> +    VALUE level;
> +    int lev;
> +
> +    rb_scan_args(argc, argv, "01", &level);
> +
> +    if (NIL_P(level))
> +     lev = 1;
> +    else
> +     lev = NUM2INT(level);
> +    if (lev < 0)
> +     rb_raise(rb_eArgError, "negative level (%d)", lev);

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
....
      rb_define_method(rb_cThread, "group", rb_thread_group, 0);
> +    rb_define_method(rb_cThread, "caller", rb_thread_caller_m, -1);

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ called caller, no?

I was suggesting that rather than raise an error here, treat this like array
indexes do and basically use size - level. (By the way,  also suggests it
might be cool to add some sort of length or size function.)

I guess I missed something, but what?


2009/6/8 SASADA Koichi <[e-mail]>

> Rocky Bernstein wrote::
> > One thing I think might be cool is rather than raising an error for a
> > negative Fixnum value is to count from the other end. So caller(-1) is
> the
> > least-recent call.
> >
> > If you want me to try my hand at extending the below, let me know.
>
> Check the following code.
>
> >>>  VALUE
> >>> +rb_thread_backtrace(VALUE thval, int lev)
> >>> +{
> >>> +    rb_thread_t *th;
> >>> +    GetThreadPtr(thval, th);
> >>> +
> >>> +    if (th->status != THREAD_KILLED && GET_THREAD() != th) {
> >>> +     lev--;
> >>> +    }
> >>> +
> >>> +    return vm_backtrace(th, lev);
> >>> +}
>
> --
> // SASADA Koichi at atdot dot net
>
>