[#6864] ruby 1.8.4 rc breaks alias_method/rails in bad ways — "Ara.T.Howard" <ara.t.howard@...>

20 messages 2005/12/09
[#6870] Re: ruby 1.8.4 rc breaks alias_method/rails in bad ways — =?ISO-8859-15?Q?Florian_Gro=DF?= <florgro@...> 2005/12/12

Ara.T.Howard wrote:

[#6872] Re: ruby 1.8.4 rc breaks alias_method/rails in bad ways — ara.t.howard@... 2005/12/12

On Tue, 13 Dec 2005, [ISO-8859-15] Florian Growrote:

[#6873] Re: ruby 1.8.4 rc breaks alias_method/rails in bad ways — James Edward Gray II <james@...> 2005/12/12

On Dec 12, 2005, at 1:19 PM, ara.t.howard@noaa.gov wrote:

[#6874] Re: ruby 1.8.4 rc breaks alias_method/rails in bad ways — ara.t.howard@... 2005/12/12

On Tue, 13 Dec 2005, James Edward Gray II wrote:

[#6891] Time.utc! and Time.localtime! — Daniel Hobe <hobe@...>

Writing a script yesterday I found out, much to my surprise, that the

16 messages 2005/12/14

[#6918] change to yaml in 1.8.4 — ara.t.howard@...

14 messages 2005/12/16

[#6934] 1.8.x, YAML, and release management — Ryan Davis <ryand-ruby@...>

I'm concerned that 1.8.3's acceptance of non-backwards-compatible

28 messages 2005/12/18

[#6996] Problems building 1.8.4 with VS8 C++ Express Edition (cl 14.00) — Austin Ziegler <halostatue@...>

Visual Studio C++ 2005 Express Edition (VS 8.0)

20 messages 2005/12/27

ruby 1.8.4 rc breaks alias_method/rails in bad ways

From: "Ara.T.Howard" <ara.t.howard@...>
Date: 2005-12-09 20:07:00 UTC
List: ruby-core #6864
i'm on a box with latest (today's) ruby and rails.  i started seeing bizzare
errors with infinite stack recursion for a simple

   ModelName.find :all

the code is kinda deep, but you can see how the problem occurs by looking at

   activerecord-1.13.1/lib/active_record/callbacks.rb +215

there we see

   object = instantiate_without_callbacks(record)

scanning up a bit we see


     def self.append_features(base) #:nodoc:
       super

       base.extend(ClassMethods)
       base.class_eval do
         class << self
           include Observable
           alias_method :instantiate_without_callbacks, :instantiate
           alias_method :instantiate, :instantiate_with_callbacks
         end


the first alias method is supposed to do

   instantiate_without_callbacks -> ActiveRecord::Base::instaniate

the second

   instantiate -> the yet to be defined ActiveRecord::Callbacks::instantiate_with_callbacks

which takes you back to line 215, shows:

     module ClassMethods #:nodoc:
       def instantiate_with_callbacks(record)

  揃揃揃       ect = instantiate_without_callbacks(record)

what is supposed to happen here is that any call to
ActiveRecord::Base::instantiate first calls instantiate_with_callbacks, which
calls instantiate_without_callbacks, which calls the, supposedly, __original__
ActiveRecord::Base::instantiate.

what __actually__ happens in this:

   >> Company.find :all
   - /usr/local/lib/ruby/gems/1.8/gems/activerecord-1.13.1/lib/active_record/base.rb:431:in `find_by_sql'
   - /usr/local/lib/ruby/gems/1.8/gems/activerecord-1.13.1/lib/active_record/base.rb:431:in `find_by_sql'
   - /usr/local/lib/ruby/gems/1.8/gems/activerecord-1.13.1/lib/active_record/base.rb:395:in `find'
   - (irb):1:in `irb_binding'
   - /usr/local/lib/ruby/1.8/irb/workspace.rb:52:in `irb_binding'
   - /usr/local/lib/ruby/1.8/irb/workspace.rb:52


   - /usr/local/lib/ruby/gems/1.8/gems/activerecord-1.13.1/lib/active_record/callbacks.rb:222:in `instantiate'
   - /usr/local/lib/ruby/gems/1.8/gems/activerecord-1.13.1/lib/active_record/base.rb:431:in `find_by_sql'
   - /usr/local/lib/ruby/gems/1.8/gems/activerecord-1.13.1/lib/active_record/base.rb:431:in `find_by_sql'
   - /usr/local/lib/ruby/gems/1.8/gems/activerecord-1.13.1/lib/active_record/base.rb:395:in `find'
   - (irb):1:in `irb_binding'
   - /usr/local/lib/ruby/1.8/irb/workspace.rb:52:in `irb_binding'
   - /usr/local/lib/ruby/1.8/irb/workspace.rb:52


   - /usr/local/lib/ruby/gems/1.8/gems/activerecord-1.13.1/lib/active_record/callbacks.rb:222:in `instantiate'
   - /usr/local/lib/ruby/gems/1.8/gems/activerecord-1.13.1/lib/active_record/base.rb:431:in `find_by_sql'
   - /usr/local/lib/ruby/gems/1.8/gems/activerecord-1.13.1/lib/active_record/base.rb:431:in `find_by_sql'
   - /usr/local/lib/ruby/gems/1.8/gems/activerecord-1.13.1/lib/active_record/base.rb:395:in `find'
   - (irb):1:in `irb_binding'
   - /usr/local/lib/ruby/1.8/irb/workspace.rb:52:in `irb_binding'
   - /usr/local/lib/ruby/1.8/irb/workspace.rb:52

and so on and so forth.  eg. - infinite recursion.

it seems the original instanciate is lost in this whole method shuffling
approach.

this code works in 1.8.2 and 1.8.3.  unless the bevhaiour of alias_methods has
changed - hard to beleive - this seems to be a bad bug.  i've tried to distill
this to a simple example with no luck.  so i'm afaid  there is more to it that
the above.  all you need do to reproduce is setup a rails dir, create a model,
and run YourModel.find :all.

system info

   root:rr# uname -srm
   FreeBSD 5.3-RELEASE i386

   root:rr# ruby -v
   ruby 1.8.4 (2005-12-01) [i386-freebsd5.3]

   root:rr# rails -v
   Rails 0.14.4

hopefully i've not overlooked something obvious here - our water pipes froze
today so i haven't been able to drink coffee.

thoughts?

-a
-- 
===============================================================================
| ara [dot] t [dot] howard [at] noaa [dot] gov
| all happiness comes from the desire for others to be happy.  all misery
| comes from the desire for oneself to be happy.
| -- bodhicaryavatara
===============================================================================



In This Thread

Prev Next