From: "H.Yamamoto" <ocean@...2.ccsnet.ne.jp>
Date: 2006-01-13T19:28:15+09:00
Subject: Re: [PATCH] Ruby 1.8.4 RDoc HTML Cleanups and HTML Language Support

-------_MULTIPART_4DACB6F0CDF780363936AF3A0880CB02_
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit


>> I have reviewed your patch, and have noticed two things.
>> 
>>   1. In your patch, xml:lang is specified in HTML4.01. Is this allowed?
>
>I think most browsers ignore attributes that they don't understand.  So,
>is it correct?  Probably not.  Will it cause problems?  Probably not.
>Does it matter?  Not really; the HTML produced with the patch is
>certainly more valid than the HTML produced without it.

Yes, and most browsers can parse <img ....> without end tag.
Why is this not good? because it's not valid xhtml. On the other hand xml:lang
is using xml namespace, so I think this is not valid html4.

>>        in lib\rdoc\generators\template\html\old_html.rb
>> 
>>        <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
>>        <html lang="%html_lang%" xml:lang="%html_lang%">
>> 
>>   2. If either charset or html_lang is not specified,
>> 
>>        rdoc ..\ruby_1_8\array.c --charset=SHIFT_JIS -o \temp
>> 
>>      I get
>> 
>>        <html xmlns="http://www.w3.org/1999/xhtml" lang="en-US" xml:lang="en-US">
>>        <head>
>>          <title>RDoc Documentation</title>
>>          <meta http-equiv="Content-Type" content="text/html; charset=SHIFT_JIS" />
>> 
>>      But this is strange. I think
>> 
>>        <html xmlns="http://www.w3.org/1999/xhtml">
>>        <head>
>>          <title>RDoc Documentation</title>
>>          <meta http-equiv="Content-Type" content="text/html; charset=SHIFT_JIS" />
>> 
>>      is more reasonable.
>
>The HTML produced before my patch had 'lang="en"' hard-coded.  From the
>patch itself:
>
>  -<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
>  +<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="%html_lang%" lang="%html_lang%">
>
>I'm not disagreeing that this behavior isn't strange, just that it was
>worse before (at least now it's configurable).

Yes, but how about this?

Index: lib/rdoc/generators/template/html/one_page_html.rb
===================================================================
RCS file: /src/ruby/lib/rdoc/generators/template/html/one_page_html.rb,v
retrieving revision 1.1.2.2
diff -u -r1.1.2.2 one_page_html.rb
--- lib/rdoc/generators/template/html/one_page_html.rb  24 Mar 2004 17:01:11 -00
00      1.1.2.2
+++ lib/rdoc/generators/template/html/one_page_html.rb  7 Jan 2006 08:38:55 -000
0
@@ -79,7 +79,7 @@

 ONE_PAGE = %{
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
-<html>
+<html lang="%html_lang%" xml:lang="%html_lang%">
 <head>
   <title>%title%</title>
   <meta http-equiv="Content-Type" content="text/html; charset=%charset%" />

Anyway, I'm not RDoc maintainer, I cannot decide intruducing new option.
I'll fix invalid xhtml error first based on your patch.

Regards,
Yamamoto



-------_MULTIPART_4DACB6F0CDF780363936AF3A0880CB02_
Content-Type: application/x-zip-compressed
Content-Disposition: attachment;
 filename="patch.zip"
Content-Transfer-Encoding: base64

UEsDBBQAAAAIAAOZLTQBSM401woAAH86AAAJAAAAcGF0Y2gudHh07Rtrc5tI8rNd5f8wwSGxT0IC
JNkWRtQmfuw6lWS3LO/WXV3uVAhGEhsEWkB+rKP77dfzAAb0sLzJOk7FJPEww3RPd093T0+3cxa4
+NpAvtevR27o1F3PHkb2uBb1tzY7n/9sbZ4fddHA87GB6nHk1KNp/6a+YLXq5dZmhJPIw5deMEQR
NLEXBkir6fBH29p0vcEAKVOkTJAS8VEkUqsoyiI2NrQ99GbqI11Vm/DD0PcNvY0UFZ6NDHmlUlkM
20Bv7IDA7iG1behNQ20w2K3NH35ASkNXqzCnwlsYGofu1Mfo/Dh0tjZR+lzHVXQTow7693OtloQ9
r4qeN+jLf6owpqdjTTYmQE4jv4rsCNu9wB5jwPC8BfP2YAZwnE6KcIxMEyH5FiGTTEbxyJ7gjnR+
cnQhIScMIzfuSNu313Ft7AWz6vbtTfZGxuzrdAzeJDRbghueUYQHBBPQBRNtPyGdjL6ZZH0IALpy
J2URdpK/RtlC3GtQhuqMNg6NAzd755gksz62JzBLgi/b7BMM9Ij6guRBfWvxtL9Tr7lhUq+il0DT
5OVuPje+iRM83pHgM1IuPPiKtm8BaoaUEN5SVDNpN5MvX1m+Nb3xkKxAiAZ4IHcaY4CAPvyUUB8E
haOOmjLGpZ3L476YJFUq4gL5zASJJNMoIEj5UCou2p6VnMYQBziykzCK66Nk7Pey/gO5kVXrL3cs
DWL7+3OehQ2jBYwUPMyqNTc0HZ3iPvEbLaSpRgt8jpr5nHTdgtNZja7ohhpNQ9dFN6S1GtV9VGFN
7oR+zHBm++oN0E5yMwF17iBplCSgD58+oWzE94KP0i568QIJLog6IdT5H6p/qO0MvcGnSTD89PuE
/MPDT/3xZPd5veiPpEwHP3CD/CBZkmC6iyaA/km5dfoxFkiQTJvZt4Bv+zbB1wm1SDm6/S90gYuZ
Uf/HDEzz5e7MrNsiwjv0Fgx34tsJptKvj/Agjh9eeRcTsVyD549FDeWkL1PXxatsaOgYO0THGkjd
NzTdaB5kKls+ItfAVlTZpmo0WgWV1ZpUZWkDA69/Pv4X+Fj5FnbMJKgsc4Rt16IbaCZe4mNLpo1s
1lmXfRrjBHQDNFnBf0y9y450FAYJDhLlAtSBnDC015GIslAaD5EzsqMYJx2Zv8iSRZXXJOoP8vU7
3eTGx90Rxgk/VuSYjPRA9WSJmgtH6MSxhMYYQoZO7EQYBxbV8hyTRAFjgkpaH5fEkBGbYFxC35sk
4uzf7UubjUrIt4Ph1B7Cpzcw2mWjHPKZotCXwTRwEqI2k3ByFLp4B9bfRbd8NxoH1TbsBm1g4OzU
cDHDDiAAf/L+eG4M/sJYRMROzwnFTOw+uB0H+/7Edl1Q1k4LXXluMupImqpSMVcWTJJaUnkabHlk
mYmLHN+OIUCgQGDqdOcl65wt6lKrikEhXAt+RGQboSVzLbMf0eXyLhOm6XqXKVZy8Cm+FzNhdS9e
nV8I/KCfzk9ODYggBgaZaHBRNdtUVLSBASYZAcqEAPLSyuQD+jkK3YcVT3faj8Jp4gUQE9iBi075
3n9ZSWWclQVV5ZLag6BYBVGxlslKgGKSy/tMXnYCnq4/TR5Yo15Fw+kYHMUqEYnkxBPboeQsEl1l
wUQgKRedyCQ7n4A6dGn73jAA0sIJnUv06orL8oDL8kCUZQENE2dhiOGgDJO9e1CBvqMxyEpxyhll
8hIdrBSnML1kjApcsWDl2dn7o7e/Hp88Y04PMcVCgs+KkaJYXJ7tA3px4y0MnZ69Pen98urHEziF
TLOXdXuUUyqQsgDopqXcE66VKLxKvwDXC6BMJgi64Znk+t5QYfADOK3ImUW0JujolkkGUOz9iTtK
wzJfW6fg78z6a3g9B6mSr5Ycj8IooZccmUo7x8/1KfKGo0SyFiilWthknR1e65Am6ZJInKQ0oN/n
5PX5/i0nsLIugeSWUtBDnZ9rKDObQp+hTamPx7bvi/Rbv9jJyOBElKGWAsmDqe/3JgAqc4u6jOH0
BDlvwPMi6MeTw500QpVk9hU2++i3LglC4bZXWT3RtJ0oDG7GiK5KQxhnGkXgjtBvOCLBHgn8uvR6
maJlEBZfIDUKTliBtTK33BqJGehaq6rvoQpvs+NsDk9qmHwot+rMYrNV1j1eiiZGbtGf/zBER29f
dbupLZOIUllgivmNumAQgv9bNDvVR0E/7/YES4wpNdSyjTOfB3c4uWzpVA+pHXETmrdAEbhshyK4
oBfzhph6kLX9xb3sdtFRt4YVngUlw105OztqvYDGiGmUkpkyib/znlEy7LWM+iENmhz3OSsFy6aG
3Nqrak0wZNZmhjyxyaIMomDD97fX2Re20ncnFz/9fNx7e9a9SC9+QLAXOP7UZcGfEH+mwUUeX/wa
k+CChNopwetPXy++zUlh0iYHXzqfBRcKAZOsUvhr1snMdGP2m1VNg41hbbYxAvIsCO7xcEYMr9Ox
r3STkMmNU0ayAzf8YRjdyDysKsR1omaVrgYLPa/gKGDn1RIfqV9e5olXupmW6KkXsMcI48yRzzYi
ewa2S/aPSwS8KA9W4A0syB7HMuIJf3WfpC1YAwPd8yPxoOGpC/pCshdLExdfLm1h0mwCFRZ9K2cU
mJHXPl6hWxK9hZGBthvwnJ4eIuIqlStMnL4BcvNdxDLANWec5NOHJBXBJ9MlDOQl4L+ddHYMDj1H
vrenw7NsPhVio02FSJs09D57f3zyzyVifHCBZVmTfujekCQJ6tvOxyFcqgNXSRnt0+eQ87R3QHmi
DQyAb6n17SDAEQU3CaKy02HfwciIjfdSHeHZA2ZIwFLkMW+YnTIjpqmpjtqZA1w5I7s75TjBbilZ
Zj0V9+w+OVL48dVTpIyG1cXD+RQ/HUUZA2smStl0ktvnidImUjWjsW/ozUI9cUVqfwnGUq5UM+Cl
UGXUqW7RpnRVpeaSxUMWqDSEEcP0nsN7c3HTiitNGvGvFQHdPfnvutqILAkXmkaLmWGLm+FZKeIr
Xo04tJ1nFcqTv0HJAEeitWdBIxFPS6VZd9Yw8YBjtmPqDXhqKutn6IS7TThRaOSOXXLDYV73Oslv
OwJQduamkzxghEdMMpw1cxkLQT0VS0gUiOMvhsnh/PV92WJwy5iS1QJ8VVhN2HsWwPDc9j2830fP
H+OvUN9cQsVqD6gv9IA6EphYzwdmABt6W/CCuqG1jJZe8IL6ul4wx1n2g02joYl+sE2Vt/1UMXoM
FSONVYy0p4rRnRUjnVWM9EdcMXo3f6v7++tDLZ3VNFibSSbGjhOOxyxvkQ1RQr96lShb9pGWifa5
SPf1b6RMdERGeZnysZeMdF4y0p9KRk8lo++2ZKS2WcmItU8lo6eS0VPJ6NssGam8ZKR+JyWjMzbR
5b8fe5/y0VLQBy0l0TQga9iVKw+xn8o45TIOMQUw8Rj/wVODGqs6aO1vqXRTI5kghd+HiO6sWZZJ
4YI4sSlgXqBpNhsN215Q/TkUID0X1vMGHhZLO7rOSjtZIedApSKlzXdR9CB5y8dQ+BDoWPHr4QtT
f3QUFRhZL/kngGzoTfTOvsmKIM0Do7Gf/7b4fdJ/ItZSArDVNJptMQHYbNPqK2vuuIA9xfd/Lb5v
Nej/JWHNHRWUe5dO7lc7edDiyYqiyT71cqxZeHB86Rr10vS18nkJ50KSuPJlU87gT1Mx0KJ5f0hP
jY50NfISfkpPIuDJCV3CEnnf2vw/UEsBAhcLFAAAAAgAA5ktNAFIzjTXCgAAfzoAAAkAAAAAAAAA
AQAgALaBAAAAAHBhdGNoLnR4dFBLBQYAAAAAAQABADcAAAD+CgAAAAA=

-------_MULTIPART_4DACB6F0CDF780363936AF3A0880CB02_--