[#7055] More on VC++ 2005 — Austin Ziegler <halostatue@...>

Okay. I've got Ruby compiling. I'm attempting to get everything in

17 messages 2006/01/05
[#7058] Re: More on VC++ 2005 — nobuyoshi nakada <nobuyoshi.nakada@...> 2006/01/06

Hi,

[#7084] mathn: ugly warnings — hadmut@... (Hadmut Danisch)

Hi,

22 messages 2006/01/10
[#7097] Re: mathn: ugly warnings — Daniel Berger <Daniel.Berger@...> 2006/01/10

Hadmut Danisch wrote:

[#7098] Design contracts and refactoring (was Re: mathn: ugly warnings) — mathew <meta@...> 2006/01/10

Daniel Berger wrote:

[#7118] Re: Design contracts and refactoring (was Re: mathn: ugly warnings) — mathew <meta@...> 2006/01/12

*Dean Wampler *<deanwampler gmail.com> writes:

[#7226] Fwd: Re: Question about massive API changes — "Sean E. Russell" <ser@...>

Hello,

23 messages 2006/01/28
[#7228] Re: Question about massive API changes — Caleb Tennis <caleb@...> 2006/01/28

>

Re: [PATCH] Ruby 1.8.4 RDoc HTML Cleanups and HTML Language Support

From: Paul Duncan <pabs@...>
Date: 2006-01-13 04:54:34 UTC
List: ruby-core #7132
* H.Yamamoto (ocean@m2.ccsnet.ne.jp) wrote:
> Hi.
> 
> >Attached is a patch against Ruby 1.8.4 which cleans up the HTML output
> >of RDoc.  Here's a list of the changes:
> >
> >* properly quote bare element attributes
> >* terminates dangling elements (e.g. <img>, <br>, <link>, etc)
> >* adds an --html-language command-line option and corresponding
> >  'html_lang' to specify HTML 
> >  language (e.g. the lang and xml:lang attributes)
> >* makes image filename suffix recognition case-insensitive
> >* converts "CVS" to the more HTML-friendly "<acronym title='Concurrent
> >  Versioning System'>CVS</acronym>"
> >* adds missing type attributes to style elements
> >* allows UTF-8 as a valid charset option, and switches 
> >  HTML template to use %charset% and %html_lang% instead of hard-
> >  coded 'utf-8' and 'en', respectively
> >* miscellaneous small changes (> => &gt;, lower-case a few element
> >  names for consistency, etc)
> >
> >
> >
> >-- 
> >Paul Duncan <pabs@pablotron.org>        OpenPGP Key ID: 0x82C29562
> >http://www.pablotron.org/               http://www.paulduncan.org/
> 
> I have reviewed your patch, and have noticed two things.
> 
>   1. In your patch, xml:lang is specified in HTML4.01. Is this allowed?

I think most browsers ignore attributes that they don't understand.  So,
is it correct?  Probably not.  Will it cause problems?  Probably not.
Does it matter?  Not really; the HTML produced with the patch is
certainly more valid than the HTML produced without it.

>        in lib\rdoc\generators\template\html\old_html.rb
> 
>        <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
>        <html lang="%html_lang%" xml:lang="%html_lang%">
> 
>   2. If either charset or html_lang is not specified,
> 
>        rdoc ..\ruby_1_8\array.c --charset=SHIFT_JIS -o \temp
> 
>      I get
> 
>        <html xmlns="http://www.w3.org/1999/xhtml" lang="en-US" xml:lang="en-US">
>        <head>
>          <title>RDoc Documentation</title>
>          <meta http-equiv="Content-Type" content="text/html; charset=SHIFT_JIS" />
> 
>      But this is strange. I think
> 
>        <html xmlns="http://www.w3.org/1999/xhtml">
>        <head>
>          <title>RDoc Documentation</title>
>          <meta http-equiv="Content-Type" content="text/html; charset=SHIFT_JIS" />
> 
>      is more reasonable.

The HTML produced before my patch had 'lang="en"' hard-coded.  From the
patch itself:

  -<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
  +<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="%html_lang%" lang="%html_lang%">

I'm not disagreeing that this behavior isn't strange, just that it was
worse before (at least now it's configurable).

-- 
Paul Duncan <pabs@pablotron.org>        OpenPGP Key ID: 0x82C29562
http://www.pablotron.org/               http://www.paulduncan.org/

Attachments (1)

signature.asc (189 Bytes, application/pgp-signature)

In This Thread